Skip to content

Commit

Permalink
Staging: lustre: Mark internal functions static in llog_cat.c
Browse files Browse the repository at this point in the history
This patch marks functions llog_cat_set_first_idx and cat_cancel_cb
static as these are used only within this file. Also since cat_cancel_cb
is made static do not export it.

This eliminates the following sparse warning:
warning: symbol * was not declared. Should it be static?

Signed-off-by: Darshana Padmadas <darshanapadmadas@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  • Loading branch information
Darshana Padmadas authored and Greg Kroah-Hartman committed Apr 1, 2015
1 parent 0bf31f0 commit 4b80af4
Showing 1 changed file with 2 additions and 3 deletions.
5 changes: 2 additions & 3 deletions drivers/staging/lustre/lustre/obdclass/llog_cat.c
Original file line number Diff line number Diff line change
Expand Up @@ -692,7 +692,7 @@ int llog_cat_reverse_process(const struct lu_env *env,
}
EXPORT_SYMBOL(llog_cat_reverse_process);

int llog_cat_set_first_idx(struct llog_handle *cathandle, int index)
static int llog_cat_set_first_idx(struct llog_handle *cathandle, int index)
{
struct llog_log_hdr *llh = cathandle->lgh_hdr;
int i, bitmap_size, idx;
Expand Down Expand Up @@ -751,7 +751,7 @@ int llog_cat_cleanup(const struct lu_env *env, struct llog_handle *cathandle,
return rc;
}

int cat_cancel_cb(const struct lu_env *env, struct llog_handle *cathandle,
static int cat_cancel_cb(const struct lu_env *env, struct llog_handle *cathandle,
struct llog_rec_hdr *rec, void *data)
{
struct llog_logid_rec *lir = (struct llog_logid_rec *)rec;
Expand Down Expand Up @@ -795,7 +795,6 @@ int cat_cancel_cb(const struct lu_env *env, struct llog_handle *cathandle,

return rc;
}
EXPORT_SYMBOL(cat_cancel_cb);

/* helper to initialize catalog llog and process it to cancel */
int llog_cat_init_and_process(const struct lu_env *env,
Expand Down

0 comments on commit 4b80af4

Please sign in to comment.