Skip to content

Commit

Permalink
ACPICA: Add const qualifier for appropriate string constants
Browse files Browse the repository at this point in the history
Mostly MODULE_NAME and printf format strings.

Signed-off-by: Bob Moore <robert.moore@intel.com>
Signed-off-by: Lin Ming <ming.m.lin@intel.com>
Signed-off-by: Len Brown <len.brown@intel.com>
Signed-off-by: Andi Kleen <ak@linux.intel.com>
  • Loading branch information
Bob Moore authored and Andi Kleen committed Jul 16, 2008
1 parent b524376 commit 4b8ed63
Show file tree
Hide file tree
Showing 11 changed files with 99 additions and 74 deletions.
5 changes: 3 additions & 2 deletions drivers/acpi/executer/exdump.c
Original file line number Diff line number Diff line change
Expand Up @@ -771,9 +771,10 @@ void acpi_ex_dump_operand(union acpi_operand_object *obj_desc, u32 depth)
void
acpi_ex_dump_operands(union acpi_operand_object **operands,
acpi_interpreter_mode interpreter_mode,
char *ident,
const char *ident,
u32 num_levels,
char *note, char *module_name, u32 line_number)
const char *note,
const char *module_name, u32 line_number)
{
u32 i;

Expand Down
24 changes: 13 additions & 11 deletions drivers/acpi/namespace/nsutils.c
Original file line number Diff line number Diff line change
Expand Up @@ -73,9 +73,9 @@ acpi_name acpi_ns_find_parent_name(struct acpi_namespace_node *node_to_search);
******************************************************************************/

void
acpi_ns_report_error(char *module_name,
acpi_ns_report_error(const char *module_name,
u32 line_number,
char *internal_name, acpi_status lookup_status)
const char *internal_name, acpi_status lookup_status)
{
acpi_status status;
u32 bad_name;
Expand Down Expand Up @@ -130,11 +130,11 @@ acpi_ns_report_error(char *module_name,
******************************************************************************/

void
acpi_ns_report_method_error(char *module_name,
acpi_ns_report_method_error(const char *module_name,
u32 line_number,
char *message,
const char *message,
struct acpi_namespace_node *prefix_node,
char *path, acpi_status method_status)
const char *path, acpi_status method_status)
{
acpi_status status;
struct acpi_namespace_node *node = prefix_node;
Expand Down Expand Up @@ -167,7 +167,8 @@ acpi_ns_report_method_error(char *module_name,
******************************************************************************/

void
acpi_ns_print_node_pathname(struct acpi_namespace_node *node, char *message)
acpi_ns_print_node_pathname(struct acpi_namespace_node *node,
const char *message)
{
struct acpi_buffer buffer;
acpi_status status;
Expand Down Expand Up @@ -296,7 +297,7 @@ u32 acpi_ns_local(acpi_object_type type)

void acpi_ns_get_internal_name_length(struct acpi_namestring_info *info)
{
char *next_external_char;
const char *next_external_char;
u32 i;

ACPI_FUNCTION_ENTRY();
Expand Down Expand Up @@ -363,7 +364,7 @@ acpi_status acpi_ns_build_internal_name(struct acpi_namestring_info *info)
{
u32 num_segments = info->num_segments;
char *internal_name = info->internal_name;
char *external_name = info->next_external_char;
const char *external_name = info->next_external_char;
char *result = NULL;
u32 i;

Expand Down Expand Up @@ -471,7 +472,8 @@ acpi_status acpi_ns_build_internal_name(struct acpi_namestring_info *info)
*
*******************************************************************************/

acpi_status acpi_ns_internalize_name(char *external_name, char **converted_name)
acpi_status
acpi_ns_internalize_name(const char *external_name, char **converted_name)
{
char *internal_name;
struct acpi_namestring_info info;
Expand Down Expand Up @@ -527,7 +529,7 @@ acpi_status acpi_ns_internalize_name(char *external_name, char **converted_name)

acpi_status
acpi_ns_externalize_name(u32 internal_name_length,
char *internal_name,
const char *internal_name,
u32 * converted_name_length, char **converted_name)
{
u32 names_index = 0;
Expand Down Expand Up @@ -821,7 +823,7 @@ u32 acpi_ns_opens_scope(acpi_object_type type)

acpi_status
acpi_ns_get_node(struct acpi_namespace_node *prefix_node,
char *pathname,
const char *pathname,
u32 flags, struct acpi_namespace_node **return_node)
{
union acpi_generic_state scope_info;
Expand Down
5 changes: 3 additions & 2 deletions drivers/acpi/utilities/utalloc.c
Original file line number Diff line number Diff line change
Expand Up @@ -309,7 +309,8 @@ acpi_ut_initialize_buffer(struct acpi_buffer * buffer,
*
******************************************************************************/

void *acpi_ut_allocate(acpi_size size, u32 component, char *module, u32 line)
void *acpi_ut_allocate(acpi_size size,
u32 component, const char *module, u32 line)
{
void *allocation;

Expand Down Expand Up @@ -353,7 +354,7 @@ void *acpi_ut_allocate(acpi_size size, u32 component, char *module, u32 line)
******************************************************************************/

void *acpi_ut_allocate_zeroed(acpi_size size,
u32 component, char *module, u32 line)
u32 component, const char *module, u32 line)
{
void *allocation;

Expand Down
26 changes: 16 additions & 10 deletions drivers/acpi/utilities/utdebug.c
Original file line number Diff line number Diff line change
Expand Up @@ -157,7 +157,8 @@ void ACPI_INTERNAL_VAR_XFACE
acpi_ut_debug_print(u32 requested_debug_level,
u32 line_number,
const char *function_name,
char *module_name, u32 component_id, char *format, ...)
const char *module_name,
u32 component_id, const char *format, ...)
{
acpi_thread_id thread_id;
va_list args;
Expand Down Expand Up @@ -228,7 +229,8 @@ void ACPI_INTERNAL_VAR_XFACE
acpi_ut_debug_print_raw(u32 requested_debug_level,
u32 line_number,
const char *function_name,
char *module_name, u32 component_id, char *format, ...)
const char *module_name,
u32 component_id, const char *format, ...)
{
va_list args;

Expand Down Expand Up @@ -261,7 +263,8 @@ ACPI_EXPORT_SYMBOL(acpi_ut_debug_print_raw)
******************************************************************************/
void
acpi_ut_trace(u32 line_number,
const char *function_name, char *module_name, u32 component_id)
const char *function_name,
const char *module_name, u32 component_id)
{

acpi_gbl_nesting_level++;
Expand Down Expand Up @@ -293,7 +296,7 @@ ACPI_EXPORT_SYMBOL(acpi_ut_trace)
void
acpi_ut_trace_ptr(u32 line_number,
const char *function_name,
char *module_name, u32 component_id, void *pointer)
const char *module_name, u32 component_id, void *pointer)
{
acpi_gbl_nesting_level++;
acpi_ut_track_stack_ptr();
Expand Down Expand Up @@ -324,7 +327,7 @@ acpi_ut_trace_ptr(u32 line_number,
void
acpi_ut_trace_str(u32 line_number,
const char *function_name,
char *module_name, u32 component_id, char *string)
const char *module_name, u32 component_id, char *string)
{

acpi_gbl_nesting_level++;
Expand Down Expand Up @@ -356,7 +359,7 @@ acpi_ut_trace_str(u32 line_number,
void
acpi_ut_trace_u32(u32 line_number,
const char *function_name,
char *module_name, u32 component_id, u32 integer)
const char *module_name, u32 component_id, u32 integer)
{

acpi_gbl_nesting_level++;
Expand Down Expand Up @@ -386,7 +389,8 @@ acpi_ut_trace_u32(u32 line_number,

void
acpi_ut_exit(u32 line_number,
const char *function_name, char *module_name, u32 component_id)
const char *function_name,
const char *module_name, u32 component_id)
{

acpi_ut_debug_print(ACPI_LV_FUNCTIONS,
Expand Down Expand Up @@ -417,7 +421,8 @@ ACPI_EXPORT_SYMBOL(acpi_ut_exit)
void
acpi_ut_status_exit(u32 line_number,
const char *function_name,
char *module_name, u32 component_id, acpi_status status)
const char *module_name,
u32 component_id, acpi_status status)
{

if (ACPI_SUCCESS(status)) {
Expand Down Expand Up @@ -458,7 +463,8 @@ ACPI_EXPORT_SYMBOL(acpi_ut_status_exit)
void
acpi_ut_value_exit(u32 line_number,
const char *function_name,
char *module_name, u32 component_id, acpi_integer value)
const char *module_name,
u32 component_id, acpi_integer value)
{

acpi_ut_debug_print(ACPI_LV_FUNCTIONS,
Expand Down Expand Up @@ -490,7 +496,7 @@ ACPI_EXPORT_SYMBOL(acpi_ut_value_exit)
void
acpi_ut_ptr_exit(u32 line_number,
const char *function_name,
char *module_name, u32 component_id, u8 * ptr)
const char *module_name, u32 component_id, u8 *ptr)
{

acpi_ut_debug_print(ACPI_LV_FUNCTIONS,
Expand Down
11 changes: 6 additions & 5 deletions drivers/acpi/utilities/utmisc.c
Original file line number Diff line number Diff line change
Expand Up @@ -1020,7 +1020,7 @@ acpi_ut_walk_package_tree(union acpi_operand_object * source_object,
******************************************************************************/

void ACPI_INTERNAL_VAR_XFACE
acpi_ut_error(char *module_name, u32 line_number, char *format, ...)
acpi_ut_error(const char *module_name, u32 line_number, const char *format, ...)
{
va_list args;

Expand All @@ -1033,8 +1033,8 @@ acpi_ut_error(char *module_name, u32 line_number, char *format, ...)
}

void ACPI_INTERNAL_VAR_XFACE
acpi_ut_exception(char *module_name,
u32 line_number, acpi_status status, char *format, ...)
acpi_ut_exception(const char *module_name,
u32 line_number, acpi_status status, const char *format, ...)
{
va_list args;

Expand All @@ -1050,7 +1050,8 @@ acpi_ut_exception(char *module_name,
EXPORT_SYMBOL(acpi_ut_exception);

void ACPI_INTERNAL_VAR_XFACE
acpi_ut_warning(char *module_name, u32 line_number, char *format, ...)
acpi_ut_warning(const char *module_name,
u32 line_number, const char *format, ...)
{
va_list args;

Expand All @@ -1063,7 +1064,7 @@ acpi_ut_warning(char *module_name, u32 line_number, char *format, ...)
}

void ACPI_INTERNAL_VAR_XFACE
acpi_ut_info(char *module_name, u32 line_number, char *format, ...)
acpi_ut_info(const char *module_name, u32 line_number, const char *format, ...)
{
va_list args;

Expand Down
5 changes: 3 additions & 2 deletions drivers/acpi/utilities/utobject.c
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,8 @@ acpi_ut_get_element_length(u8 object_type,
*
******************************************************************************/

union acpi_operand_object *acpi_ut_create_internal_object_dbg(char *module_name,
union acpi_operand_object *acpi_ut_create_internal_object_dbg(const char
*module_name,
u32 line_number,
u32 component_id,
acpi_object_type
Expand Down Expand Up @@ -347,7 +348,7 @@ u8 acpi_ut_valid_internal_object(void *object)
*
******************************************************************************/

void *acpi_ut_allocate_object_desc_dbg(char *module_name,
void *acpi_ut_allocate_object_desc_dbg(const char *module_name,
u32 line_number, u32 component_id)
{
union acpi_operand_object *object;
Expand Down
5 changes: 3 additions & 2 deletions include/acpi/acinterp.h
Original file line number Diff line number Diff line change
Expand Up @@ -367,9 +367,10 @@ void acpi_ex_dump_operand(union acpi_operand_object *obj_desc, u32 depth);
void
acpi_ex_dump_operands(union acpi_operand_object **operands,
acpi_interpreter_mode interpreter_mode,
char *ident,
const char *ident,
u32 num_levels,
char *note, char *module_name, u32 line_number);
const char *note,
const char *module_name, u32 line_number);

#ifdef ACPI_FUTURE_USAGE
void
Expand Down
4 changes: 2 additions & 2 deletions include/acpi/aclocal.h
Original file line number Diff line number Diff line change
Expand Up @@ -282,8 +282,8 @@ struct acpi_predefined_names {
/* Info structure used to convert external<->internal namestrings */

struct acpi_namestring_info {
char *external_name;
char *next_external_char;
const char *external_name;
const char *next_external_char;
char *internal_name;
u32 length;
u32 num_segments;
Expand Down
2 changes: 1 addition & 1 deletion include/acpi/acmacros.h
Original file line number Diff line number Diff line change
Expand Up @@ -414,7 +414,7 @@ struct acpi_integer_overlay {
* error messages. The __FILE__ macro is not very useful for this, because it
* often includes the entire pathname to the module
*/
#define ACPI_MODULE_NAME(name) static char ACPI_UNUSED_VAR _acpi_module_name[] = name;
#define ACPI_MODULE_NAME(name) static const char ACPI_UNUSED_VAR _acpi_module_name[] = name;
#else
#define ACPI_MODULE_NAME(name)
#endif
Expand Down
20 changes: 11 additions & 9 deletions include/acpi/acnamesp.h
Original file line number Diff line number Diff line change
Expand Up @@ -199,7 +199,7 @@ acpi_ns_pattern_match(struct acpi_namespace_node *obj_node, char *search_for);

acpi_status
acpi_ns_get_node(struct acpi_namespace_node *prefix_node,
char *external_pathname,
const char *external_pathname,
u32 flags, struct acpi_namespace_node **out_node);

acpi_size acpi_ns_get_pathname_length(struct acpi_namespace_node *node);
Expand Down Expand Up @@ -263,28 +263,30 @@ acpi_object_type acpi_ns_get_type(struct acpi_namespace_node *node);
u32 acpi_ns_local(acpi_object_type type);

void
acpi_ns_report_error(char *module_name,
acpi_ns_report_error(const char *module_name,
u32 line_number,
char *internal_name, acpi_status lookup_status);
const char *internal_name, acpi_status lookup_status);

void
acpi_ns_report_method_error(char *module_name,
acpi_ns_report_method_error(const char *module_name,
u32 line_number,
char *message,
const char *message,
struct acpi_namespace_node *node,
char *path, acpi_status lookup_status);
const char *path, acpi_status lookup_status);

void acpi_ns_print_node_pathname(struct acpi_namespace_node *node, char *msg);
void
acpi_ns_print_node_pathname(struct acpi_namespace_node *node, const char *msg);

acpi_status acpi_ns_build_internal_name(struct acpi_namestring_info *info);

void acpi_ns_get_internal_name_length(struct acpi_namestring_info *info);

acpi_status acpi_ns_internalize_name(char *dotted_name, char **converted_name);
acpi_status
acpi_ns_internalize_name(const char *dotted_name, char **converted_name);

acpi_status
acpi_ns_externalize_name(u32 internal_name_length,
char *internal_name,
const char *internal_name,
u32 * converted_name_length, char **converted_name);

struct acpi_namespace_node *acpi_ns_map_handle_to_node(acpi_handle handle);
Expand Down
Loading

0 comments on commit 4b8ed63

Please sign in to comment.