Skip to content

Commit

Permalink
AUDIT: Fix user pointer deref thinko in sys_socketcall().
Browse files Browse the repository at this point in the history
I cunningly put the audit call immediately after the 
copy_from_user().... but used the _userspace_ copy of the args still. 
Let's not do that.

Signed-off-by: David Woodhouse <dwmw2@infradead.org>
  • Loading branch information
David Woodhouse committed Jun 2, 2005
1 parent 8f37d47 commit 4bcff1b
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion net/socket.c
Original file line number Diff line number Diff line change
Expand Up @@ -1908,7 +1908,7 @@ asmlinkage long sys_socketcall(int call, unsigned long __user *args)
if (copy_from_user(a, args, nargs[call]))
return -EFAULT;

err = audit_socketcall(nargs[call]/sizeof(unsigned long), args);
err = audit_socketcall(nargs[call]/sizeof(unsigned long), a);
if (err)
return err;

Expand Down

0 comments on commit 4bcff1b

Please sign in to comment.