Skip to content

Commit

Permalink
sh/kernel/ cleanups
Browse files Browse the repository at this point in the history
This patch contains the following cleanups:
- make the following needlessly global code static:
  - cf-enabler.c: cf_init()
  - cpu/clock.c: __clk_enable()
  - cpu/clock.c: __clk_disable()
  - process_32.c: default_idle()
  - time_32.c: struct clocksource_sh
  - timers/timer-tmu.c: struct tmu_timer_ops
- remove the following unused functions (no CONFIG_BLK_DEV_FD on sh):
  - process_{32,64}.c: disable_hlt()
  - process_{32,64}.c: enable_hlt()

Signed-off-by: Adrian Bunk <bunk@kernel.org>
Signed-off-by: Paul Mundt <lethal@linux-sh.org>
  • Loading branch information
Adrian Bunk authored and Paul Mundt committed Jul 28, 2008
1 parent 6241003 commit 4c1cfab
Show file tree
Hide file tree
Showing 9 changed files with 6 additions and 42 deletions.
2 changes: 1 addition & 1 deletion arch/sh/kernel/cf-enabler.c
Original file line number Diff line number Diff line change
Expand Up @@ -157,7 +157,7 @@ static int __init cf_init_se(void)
}
#endif

int __init cf_init(void)
static int __init cf_init(void)
{
if (mach_is_se() || mach_is_7722se() || mach_is_7721se())
return cf_init_se();
Expand Down
6 changes: 2 additions & 4 deletions arch/sh/kernel/cpu/clock.c
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ static void propagate_rate(struct clk *clk)
}
}

int __clk_enable(struct clk *clk)
static int __clk_enable(struct clk *clk)
{
/*
* See if this is the first time we're enabling the clock, some
Expand All @@ -111,7 +111,6 @@ int __clk_enable(struct clk *clk)

return 0;
}
EXPORT_SYMBOL_GPL(__clk_enable);

int clk_enable(struct clk *clk)
{
Expand All @@ -131,7 +130,7 @@ static void clk_kref_release(struct kref *kref)
/* Nothing to do */
}

void __clk_disable(struct clk *clk)
static void __clk_disable(struct clk *clk)
{
int count = kref_put(&clk->kref, clk_kref_release);

Expand All @@ -143,7 +142,6 @@ void __clk_disable(struct clk *clk)
clk->ops->disable(clk);
}
}
EXPORT_SYMBOL_GPL(__clk_disable);

void clk_disable(struct clk *clk)
{
Expand Down
14 changes: 1 addition & 13 deletions arch/sh/kernel/process_32.c
Original file line number Diff line number Diff line change
Expand Up @@ -34,18 +34,6 @@ void (*pm_idle)(void);
void (*pm_power_off)(void);
EXPORT_SYMBOL(pm_power_off);

void disable_hlt(void)
{
hlt_counter++;
}
EXPORT_SYMBOL(disable_hlt);

void enable_hlt(void)
{
hlt_counter--;
}
EXPORT_SYMBOL(enable_hlt);

static int __init nohlt_setup(char *__unused)
{
hlt_counter = 1;
Expand All @@ -60,7 +48,7 @@ static int __init hlt_setup(char *__unused)
}
__setup("hlt", hlt_setup);

void default_idle(void)
static void default_idle(void)
{
if (!hlt_counter) {
clear_thread_flag(TIF_POLLING_NRFLAG);
Expand Down
10 changes: 0 additions & 10 deletions arch/sh/kernel/process_64.c
Original file line number Diff line number Diff line change
Expand Up @@ -36,16 +36,6 @@ static int hlt_counter = 1;

#define HARD_IDLE_TIMEOUT (HZ / 3)

void disable_hlt(void)
{
hlt_counter++;
}

void enable_hlt(void)
{
hlt_counter--;
}

static int __init nohlt_setup(char *__unused)
{
hlt_counter = 1;
Expand Down
2 changes: 1 addition & 1 deletion arch/sh/kernel/time_32.c
Original file line number Diff line number Diff line change
Expand Up @@ -211,7 +211,7 @@ unsigned long sh_hpt_frequency = 0;

#define NSEC_PER_CYC_SHIFT 10

struct clocksource clocksource_sh = {
static struct clocksource clocksource_sh = {
.name = "SuperH",
.rating = 200,
.mask = CLOCKSOURCE_MASK(32),
Expand Down
2 changes: 1 addition & 1 deletion arch/sh/kernel/timers/timer-tmu.c
Original file line number Diff line number Diff line change
Expand Up @@ -209,7 +209,7 @@ static int tmu_timer_init(void)
return 0;
}

struct sys_timer_ops tmu_timer_ops = {
static struct sys_timer_ops tmu_timer_ops = {
.init = tmu_timer_init,
.start = tmu_timer_start,
.stop = tmu_timer_stop,
Expand Down
3 changes: 0 additions & 3 deletions include/asm-sh/clock.h
Original file line number Diff line number Diff line change
Expand Up @@ -41,9 +41,6 @@ void arch_init_clk_ops(struct clk_ops **, int type);
/* arch/sh/kernel/cpu/clock.c */
int clk_init(void);

int __clk_enable(struct clk *);
void __clk_disable(struct clk *);

void clk_recalc_rate(struct clk *);

int clk_register(struct clk *);
Expand Down
8 changes: 0 additions & 8 deletions include/asm-sh/system.h
Original file line number Diff line number Diff line change
Expand Up @@ -148,14 +148,6 @@ extern unsigned long cached_to_uncached;

extern struct dentry *sh_debugfs_root;

/* XXX
* disable hlt during certain critical i/o operations
*/
#define HAVE_DISABLE_HLT
void disable_hlt(void);
void enable_hlt(void);

void default_idle(void);
void per_cpu_trap_init(void);

asmlinkage void break_point_trap(void);
Expand Down
1 change: 0 additions & 1 deletion include/asm-sh/timer.h
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,5 @@ struct sys_timer *get_sys_timer(void);
/* arch/sh/kernel/time.c */
void handle_timer_tick(void);
extern unsigned long sh_hpt_frequency;
extern struct clocksource clocksource_sh;

#endif /* __ASM_SH_TIMER_H */

0 comments on commit 4c1cfab

Please sign in to comment.