Skip to content

Commit

Permalink
of/mips: Cleanup some include directives/files.
Browse files Browse the repository at this point in the history
The __init directives should go on the definitions of things, not the
declaration, also __init is meaningless for inline functions, so
remove it from prom.h.  This allows us to get rid of a useless
#include, but most of the rest of them are useless too, so kill them
as well.

If of_i2c.c needs irq definitions, it should include linux/irq.h
directly, not assume indirect inclusion via asm/prom.h.

Signed-off-by: David Daney <ddaney@caviumnetworks.com>
Acked-by: Ralf Baechle <ralf@linux-mips.org>
Signed-off-by: Grant Likely <grant.likely@secretlab.ca>
  • Loading branch information
David Daney authored and Grant Likely committed Oct 21, 2010
1 parent f2ffa5a commit 4c60071
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 6 deletions.
8 changes: 2 additions & 6 deletions arch/mips/include/asm/prom.h
Original file line number Diff line number Diff line change
Expand Up @@ -12,10 +12,6 @@
#define __ASM_MIPS_PROM_H

#ifdef CONFIG_OF
#include <linux/init.h>

#include <asm/setup.h>
#include <asm/irq.h>
#include <asm/bootinfo.h>

/* which is compatible with the flattened device tree (FDT) */
Expand All @@ -27,9 +23,9 @@ extern int early_init_dt_scan_memory_arch(unsigned long node,
extern int reserve_mem_mach(unsigned long addr, unsigned long size);
extern void free_mem_mach(unsigned long addr, unsigned long size);

extern void __init device_tree_init(void);
extern void device_tree_init(void);
#else /* CONFIG_OF */
static inline void __init device_tree_init(void) { }
static inline void device_tree_init(void) { }
#endif /* CONFIG_OF */

#endif /* _ASM_MIPS_PROM_H */
1 change: 1 addition & 0 deletions drivers/of/of_i2c.c
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
*/

#include <linux/i2c.h>
#include <linux/irq.h>
#include <linux/of.h>
#include <linux/of_i2c.h>
#include <linux/of_irq.h>
Expand Down

0 comments on commit 4c60071

Please sign in to comment.