Skip to content

Commit

Permalink
usb: musb: host: Issue a memory barrier before starting DMA
Browse files Browse the repository at this point in the history
This patch fixes the issue which was observed while transfering
a large file ( > 20MB) over USB (OMAP MUSB controller acts as USB host)
to an attached USB thumb drive.

It was found that CDB field of CBW packet was set to 0x0. This was
due to missing a barrier before DMA engine starts transfer.
This  buffer is  allocated using dma_alloc_coherent which gives
non-cacheble but bufferable memory and hence needed a write
memory barrier to flush the write buffer.

More info on this thread is here:
	http://www.spinics.net/lists/linux-omap/msg33987.html

Signed-off-by: Santosh Shilimkar <santosh.shilimkar@ti.com>
Signed-off-by: Maulik Mankad <x0082077@ti.com>
Cc: Russell King <rmk+kernel@arm.linux.org.uk>
Signed-off-by: Felipe Balbi <balbi@ti.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
  • Loading branch information
Santosh Shilimkar authored and Greg Kroah-Hartman committed Sep 24, 2010
1 parent 66af83d commit 4c64733
Showing 1 changed file with 6 additions and 0 deletions.
6 changes: 6 additions & 0 deletions drivers/usb/musb/musb_host.c
Original file line number Diff line number Diff line change
Expand Up @@ -660,6 +660,12 @@ static bool musb_tx_dma_program(struct dma_controller *dma,

qh->segsize = length;

/*
* Ensure the data reaches to main memory before starting
* DMA transfer
*/
wmb();

if (!dma->channel_program(channel, pkt_size, mode,
urb->transfer_dma + offset, length)) {
dma->channel_release(channel);
Expand Down

0 comments on commit 4c64733

Please sign in to comment.