Skip to content

Commit

Permalink
hrtimer: incorporate feedback from Peter Zijlstra
Browse files Browse the repository at this point in the history
(based on  lkml review)
* use rt_task()
* task_nice() has a sign

Signed-off-by: Arjan van de Ven <arjan@linux.intel.com>
  • Loading branch information
Arjan van de Ven committed Sep 7, 2008
1 parent da8f2e1 commit 4ce105d
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 4 deletions.
5 changes: 2 additions & 3 deletions fs/select.c
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ static unsigned long __estimate_accuracy(struct timespec *tv)
unsigned long slack;
int divfactor = 1000;

if (task_nice(current))
if (task_nice(current) > 0)
divfactor = divfactor / 5;

slack = tv->tv_nsec / divfactor;
Expand All @@ -66,8 +66,7 @@ static unsigned long estimate_accuracy(struct timespec *tv)
* Realtime tasks get a slack of 0 for obvious reasons.
*/

if (current->policy == SCHED_FIFO ||
current->policy == SCHED_RR)
if (rt_task(current))
return 0;

ktime_get_ts(&now);
Expand Down
2 changes: 1 addition & 1 deletion include/linux/hrtimer.h
Original file line number Diff line number Diff line change
Expand Up @@ -363,7 +363,7 @@ static inline int hrtimer_start_expires(struct hrtimer *timer,
soft = hrtimer_get_softexpires(timer);
hard = hrtimer_get_expires(timer);
delta = ktime_to_ns(ktime_sub(hard, soft));
return hrtimer_start_range_ns(timer, hrtimer_get_expires(timer), delta, mode);
return hrtimer_start_range_ns(timer, soft, delta, mode);
}

static inline int hrtimer_restart(struct hrtimer *timer)
Expand Down

0 comments on commit 4ce105d

Please sign in to comment.