Skip to content

Commit

Permalink
ACPICA: Debugger: Remove some unecessary NULL checks
Browse files Browse the repository at this point in the history
ACPICA commit 36fcc1b98def3fb6e20cf5e877ffc3c1592d0140

Local strupr function already checks for NULL pointers.

Original linux patch submitted by:
Markus Elfring <elfring@users.sourceforge.net>

Link: https://github.com/acpica/acpica/commit/36fcc1b9
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: Bob Moore <robert.moore@intel.com>
Signed-off-by: Lv Zheng <lv.zheng@intel.com>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
  • Loading branch information
Markus Elfring authored and Rafael J. Wysocki committed Jan 1, 2016
1 parent 395ec73 commit 4d16ca1
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 10 deletions.
9 changes: 2 additions & 7 deletions drivers/acpi/acpica/dbcmds.c
Original file line number Diff line number Diff line change
Expand Up @@ -1131,13 +1131,8 @@ void acpi_db_trace(char *enable_arg, char *method_arg, char *once_arg)
u32 debug_layer = 0;
u32 flags = 0;

if (enable_arg) {
acpi_ut_strupr(enable_arg);
}

if (once_arg) {
acpi_ut_strupr(once_arg);
}
acpi_ut_strupr(enable_arg);
acpi_ut_strupr(once_arg);

if (method_arg) {
if (acpi_db_trace_method_name) {
Expand Down
4 changes: 1 addition & 3 deletions drivers/acpi/acpica/dbinput.c
Original file line number Diff line number Diff line change
Expand Up @@ -625,9 +625,7 @@ static u32 acpi_db_get_line(char *input_buffer)

/* Uppercase the actual command */

if (acpi_gbl_db_args[0]) {
acpi_ut_strupr(acpi_gbl_db_args[0]);
}
acpi_ut_strupr(acpi_gbl_db_args[0]);

count = i;
if (count) {
Expand Down

0 comments on commit 4d16ca1

Please sign in to comment.