Skip to content

Commit

Permalink
---
Browse files Browse the repository at this point in the history
yaml
---
r: 308983
b: refs/heads/master
c: 4796dd2
h: refs/heads/master
i:
  308981: 6a07907
  308979: ed6bbe4
  308975: c9e0749
v: v3
  • Loading branch information
Stephen Boyd authored and Linus Torvalds committed May 29, 2012
1 parent d6dfdc1 commit 4d2ecac
Show file tree
Hide file tree
Showing 4 changed files with 33 additions and 10 deletions.
2 changes: 1 addition & 1 deletion [refs]
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
---
refs/heads/master: 05a6c8a9226599f921bd0b6e439dbc04df96a6fc
refs/heads/master: 4796dd200db943e36f876e7029552212e5bbdf33
7 changes: 7 additions & 0 deletions trunk/include/linux/kallsyms.h
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@ const char *kallsyms_lookup(unsigned long addr,

/* Look up a kernel symbol and return it in a text buffer. */
extern int sprint_symbol(char *buffer, unsigned long address);
extern int sprint_symbol_no_offset(char *buffer, unsigned long address);
extern int sprint_backtrace(char *buffer, unsigned long address);

/* Look up a kernel symbol and print it to the kernel messages. */
Expand Down Expand Up @@ -80,6 +81,12 @@ static inline int sprint_symbol(char *buffer, unsigned long addr)
return 0;
}

static inline int sprint_symbol_no_offset(char *buffer, unsigned long addr)
{
*buffer = '\0';
return 0;
}

static inline int sprint_backtrace(char *buffer, unsigned long addr)
{
*buffer = '\0';
Expand Down
32 changes: 24 additions & 8 deletions trunk/kernel/kallsyms.c
Original file line number Diff line number Diff line change
Expand Up @@ -343,7 +343,7 @@ int lookup_symbol_attrs(unsigned long addr, unsigned long *size,

/* Look up a kernel symbol and return it in a text buffer. */
static int __sprint_symbol(char *buffer, unsigned long address,
int symbol_offset)
int symbol_offset, int add_offset)
{
char *modname;
const char *name;
Expand All @@ -358,13 +358,13 @@ static int __sprint_symbol(char *buffer, unsigned long address,
if (name != buffer)
strcpy(buffer, name);
len = strlen(buffer);
buffer += len;
offset -= symbol_offset;

if (add_offset)
len += sprintf(buffer + len, "+%#lx/%#lx", offset, size);

if (modname)
len += sprintf(buffer, "+%#lx/%#lx [%s]", offset, size, modname);
else
len += sprintf(buffer, "+%#lx/%#lx", offset, size);
len += sprintf(buffer + len, " [%s]", modname);

return len;
}
Expand All @@ -382,11 +382,27 @@ static int __sprint_symbol(char *buffer, unsigned long address,
*/
int sprint_symbol(char *buffer, unsigned long address)
{
return __sprint_symbol(buffer, address, 0);
return __sprint_symbol(buffer, address, 0, 1);
}

EXPORT_SYMBOL_GPL(sprint_symbol);

/**
* sprint_symbol_no_offset - Look up a kernel symbol and return it in a text buffer
* @buffer: buffer to be stored
* @address: address to lookup
*
* This function looks up a kernel symbol with @address and stores its name
* and module name to @buffer if possible. If no symbol was found, just saves
* its @address as is.
*
* This function returns the number of bytes stored in @buffer.
*/
int sprint_symbol_no_offset(char *buffer, unsigned long address)
{
return __sprint_symbol(buffer, address, 0, 0);
}
EXPORT_SYMBOL_GPL(sprint_symbol_no_offset);

/**
* sprint_backtrace - Look up a backtrace symbol and return it in a text buffer
* @buffer: buffer to be stored
Expand All @@ -403,7 +419,7 @@ EXPORT_SYMBOL_GPL(sprint_symbol);
*/
int sprint_backtrace(char *buffer, unsigned long address)
{
return __sprint_symbol(buffer, address, -1);
return __sprint_symbol(buffer, address, -1, 1);
}

/* Look up a kernel symbol and print it to the kernel messages. */
Expand Down
2 changes: 1 addition & 1 deletion trunk/lib/vsprintf.c
Original file line number Diff line number Diff line change
Expand Up @@ -436,7 +436,7 @@ char *symbol_string(char *buf, char *end, void *ptr,
else if (ext != 'f' && ext != 's')
sprint_symbol(sym, value);
else
kallsyms_lookup(value, NULL, NULL, NULL, sym);
sprint_symbol_no_offset(sym, value);

return string(buf, end, sym, spec);
#else
Expand Down

0 comments on commit 4d2ecac

Please sign in to comment.