Skip to content

Commit

Permalink
[PATCH] gianfar: Use new PHY_ID_FMT macro
Browse files Browse the repository at this point in the history
Make the driver produce the string used by phy_connect and have board specific
code pass the integer mii bus id and phy device id for the specific controller
instance.

Signed-off-by: Kumar Gala <galak@kernel.crashing.org>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Jeff Garzik <jgarzik@pobox.com>
  • Loading branch information
Kumar Gala authored and Jeff Garzik committed Jan 12, 2006
1 parent a4d00f1 commit 4d3248a
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 2 deletions.
5 changes: 4 additions & 1 deletion drivers/net/gianfar.c
Original file line number Diff line number Diff line change
Expand Up @@ -399,12 +399,15 @@ static int init_phy(struct net_device *dev)
priv->einfo->device_flags & FSL_GIANFAR_DEV_HAS_GIGABIT ?
SUPPORTED_1000baseT_Full : 0;
struct phy_device *phydev;
char phy_id[BUS_ID_SIZE];

priv->oldlink = 0;
priv->oldspeed = 0;
priv->oldduplex = -1;

phydev = phy_connect(dev, priv->einfo->bus_id, &adjust_link, 0);
snprintf(phy_id, BUS_ID_SIZE, PHY_ID_FMT, priv->einfo->bus_id, priv->einfo->phy_id);

phydev = phy_connect(dev, phy_id, &adjust_link, 0);

if (IS_ERR(phydev)) {
printk(KERN_ERR "%s: Could not attach to PHY\n", dev->name);
Expand Down
3 changes: 2 additions & 1 deletion include/linux/fsl_devices.h
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,8 @@ struct gianfar_platform_data {

/* board specific information */
u32 board_flags;
const char *bus_id;
u32 bus_id;
u32 phy_id;
u8 mac_addr[6];
};

Expand Down

0 comments on commit 4d3248a

Please sign in to comment.