Skip to content

Commit

Permalink
mtd: cafe_nand.c: use mtd_device_parse_register
Browse files Browse the repository at this point in the history
Replace custom invocations of parse_mtd_partitions and mtd_device_register
with common mtd_device_parse_register call. This would bring: standard
handling of all errors, fallback to default partitions, etc.

Fixed by Brian Norris <computersforpeace@gmail.com>

Signed-off-by: Dmitry Eremin-Solenikov <dbaryshkov@gmail.com>
Signed-off-by: Artem Bityutskiy <Artem.Bityutskiy@nokia.com>
  • Loading branch information
Dmitry Eremin-Solenikov authored and Artem Bityutskiy committed Sep 11, 2011
1 parent 58171cb commit 4d32de8
Showing 1 changed file with 2 additions and 12 deletions.
14 changes: 2 additions & 12 deletions drivers/mtd/nand/cafe_nand.c
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,6 @@

struct cafe_priv {
struct nand_chip nand;
struct mtd_partition *parts;
struct pci_dev *pdev;
void __iomem *mmio;
struct rs_control *rs;
Expand Down Expand Up @@ -630,8 +629,6 @@ static int __devinit cafe_nand_probe(struct pci_dev *pdev,
struct cafe_priv *cafe;
uint32_t ctrl;
int err = 0;
struct mtd_partition *parts;
int nr_parts;

/* Very old versions shared the same PCI ident for all three
functions on the chip. Verify the class too... */
Expand Down Expand Up @@ -800,16 +797,9 @@ static int __devinit cafe_nand_probe(struct pci_dev *pdev,

pci_set_drvdata(pdev, mtd);

/* We register the whole device first, separate from the partitions */
mtd_device_register(mtd, NULL, 0);

mtd->name = "cafe_nand";
nr_parts = parse_mtd_partitions(mtd, part_probes, &parts, 0);
if (nr_parts > 0) {
cafe->parts = parts;
dev_info(&cafe->pdev->dev, "%d partitions found\n", nr_parts);
mtd_device_register(mtd, parts, nr_parts);
}
mtd_device_parse_register(mtd, part_probes, 0, NULL, 0);

goto out;

out_irq:
Expand Down

0 comments on commit 4d32de8

Please sign in to comment.