Skip to content

Commit

Permalink
[NETFILTER]: H.323 helper: fix sequence extension parsing
Browse files Browse the repository at this point in the history
When parsing unknown sequence extensions the "son"-pointer points behind
the last known extension for this type, don't try to interpret it.

Signed-off-by: Patrick McHardy <kaber@trash.net>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Patrick McHardy authored and David S. Miller committed May 23, 2006
1 parent 7185989 commit 4d942d8
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion net/ipv4/netfilter/ip_conntrack_helper_h323_asn1.c
Original file line number Diff line number Diff line change
Expand Up @@ -555,7 +555,7 @@ int decode_seq(bitstr_t * bs, field_t * f, char *base, int level)

/* Decode the extension components */
for (opt = 0; opt < bmp2_len; opt++, i++, son++) {
if (son->attr & STOP) {
if (i < f->ub && son->attr & STOP) {
PRINT("%*.s%s\n", (level + 1) * TAB_SIZE, " ",
son->name);
return H323_ERROR_STOP;
Expand Down

0 comments on commit 4d942d8

Please sign in to comment.