Skip to content

Commit

Permalink
xen/blkfront: use tagged queuing for barriers
Browse files Browse the repository at this point in the history
When barriers are supported, then use QUEUE_ORDERED_TAG to tell the block
subsystem that it doesn't need to do anything else with the barriers.
Previously we used ORDERED_DRAIN which caused the block subsystem to
drain all pending IO before submitting the barrier, which would be
very expensive.

Signed-off-by: Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com>
  • Loading branch information
Jeremy Fitzhardinge authored and Jens Axboe committed Aug 7, 2010
1 parent e96f6ab commit 4dab46f
Showing 1 changed file with 13 additions and 4 deletions.
17 changes: 13 additions & 4 deletions drivers/block/xen-blkfront.c
Original file line number Diff line number Diff line change
Expand Up @@ -420,9 +420,19 @@ static int xlvbd_init_blk_queue(struct gendisk *gd, u16 sector_size)
static int xlvbd_barrier(struct blkfront_info *info)
{
int err;
unsigned ordered = QUEUE_ORDERED_NONE;

err = blk_queue_ordered(info->rq,
info->feature_barrier ? QUEUE_ORDERED_DRAIN : QUEUE_ORDERED_NONE);
/*
* If we don't have barrier support, then there's really no
* way to guarantee write ordering, so we really just have to
* send writes to the backend and hope for the best. If
* barriers are supported then we can treat them as proper
* ordering tags.
*/
if (info->feature_barrier)
ordered = QUEUE_ORDERED_TAG;

err = blk_queue_ordered(info->rq, ordered);

if (err)
return err;
Expand Down Expand Up @@ -509,8 +519,7 @@ static int xlvbd_alloc_gendisk(blkif_sector_t capacity,
info->rq = gd->queue;
info->gd = gd;

if (info->feature_barrier)
xlvbd_barrier(info);
xlvbd_barrier(info);

if (vdisk_info & VDISK_READONLY)
set_disk_ro(gd, 1);
Expand Down

0 comments on commit 4dab46f

Please sign in to comment.