Skip to content

Commit

Permalink
[PATCH] zd1211rw: Removed unneeded packed attributes
Browse files Browse the repository at this point in the history
Inspired by an e-mail by Stephen Hemminger I decided to remove all
unneeded packed attributes from the code where the member variables are
already aligned. This avoids horrible code being generated on some
architectures.

Signed-off-by: Ulrich Kunitz <kune@deine-taler.de>
Signed-off-by: Daniel Drake <dsd@gentoo.org>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
  • Loading branch information
Ulrich Kunitz authored and John W. Linville committed Sep 11, 2006
1 parent fc3e39b commit 4e1bbd8
Show file tree
Hide file tree
Showing 4 changed files with 11 additions and 11 deletions.
2 changes: 1 addition & 1 deletion drivers/net/wireless/zd1211rw/zd_ieee80211.h
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ struct cck_plcp_header {
u8 service;
__le16 length;
__le16 crc16;
} __attribute__((packed));
};

static inline u8 zd_cck_plcp_header_rate(const struct cck_plcp_header *header)
{
Expand Down
2 changes: 1 addition & 1 deletion drivers/net/wireless/zd1211rw/zd_mac.c
Original file line number Diff line number Diff line change
Expand Up @@ -714,7 +714,7 @@ struct zd_rt_hdr {
u8 rt_rate;
u16 rt_channel;
u16 rt_chbitmask;
} __attribute__((packed));
};

static void fill_rt_header(void *buffer, struct zd_mac *mac,
const struct ieee80211_rx_stats *stats,
Expand Down
4 changes: 2 additions & 2 deletions drivers/net/wireless/zd1211rw/zd_mac.h
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ struct zd_ctrlset {
struct rx_length_info {
__le16 length[3];
__le16 tag;
} __attribute__((packed));
};

#define RX_LENGTH_INFO_TAG 0x697e

Expand All @@ -93,7 +93,7 @@ struct rx_status {
u8 signal_quality_ofdm;
u8 decryption_type;
u8 frame_status;
} __attribute__((packed));
};

/* rx_status field decryption_type */
#define ZD_RX_NO_WEP 0
Expand Down
14 changes: 7 additions & 7 deletions drivers/net/wireless/zd1211rw/zd_usb.h
Original file line number Diff line number Diff line change
Expand Up @@ -74,17 +74,17 @@ enum control_requests {
struct usb_req_read_regs {
__le16 id;
__le16 addr[0];
} __attribute__((packed));
};

struct reg_data {
__le16 addr;
__le16 value;
} __attribute__((packed));
};

struct usb_req_write_regs {
__le16 id;
struct reg_data reg_writes[0];
} __attribute__((packed));
};

enum {
RF_IF_LE = 0x02,
Expand All @@ -101,7 +101,7 @@ struct usb_req_rfwrite {
/* RF2595: 24 */
__le16 bit_values[0];
/* (CR203 & ~(RF_IF_LE | RF_CLK | RF_DATA)) | (bit ? RF_DATA : 0) */
} __attribute__((packed));
};

/* USB interrupt */

Expand All @@ -118,20 +118,20 @@ enum usb_int_flags {
struct usb_int_header {
u8 type; /* must always be 1 */
u8 id;
} __attribute__((packed));
};

struct usb_int_regs {
struct usb_int_header hdr;
struct reg_data regs[0];
} __attribute__((packed));
};

struct usb_int_retry_fail {
struct usb_int_header hdr;
u8 new_rate;
u8 _dummy;
u8 addr[ETH_ALEN];
u8 ibss_wakeup_dest;
} __attribute__((packed));
};

struct read_regs_int {
struct completion completion;
Expand Down

0 comments on commit 4e1bbd8

Please sign in to comment.