Skip to content

Commit

Permalink
hwmon: (tmp401) Drop redundant safety on cache lifetime
Browse files Browse the repository at this point in the history
time_after (as opposed to time_after_equal) already ensures that the
cache lifetime is at least as much as requested. There is no point in
manually adding another jiffy to that value, and this can confuse the
reader into wrong interpretation.

Signed-off-by: Jean Delvare <khali@linux-fr.org>
Cc: Imre Deak <imre.deak@intel.com>
Cc: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
  • Loading branch information
Jean Delvare authored and Guenter Roeck committed May 19, 2013
1 parent ecacb0b commit 4e2284d
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/hwmon/tmp401.c
Original file line number Diff line number Diff line change
Expand Up @@ -240,7 +240,7 @@ static struct tmp401_data *tmp401_update_device(struct device *dev)
mutex_lock(&data->update_lock);

next_update = data->last_updated +
msecs_to_jiffies(data->update_interval) + 1;
msecs_to_jiffies(data->update_interval);
if (time_after(jiffies, next_update) || !data->valid) {
if (data->kind != tmp432) {
/*
Expand Down

0 comments on commit 4e2284d

Please sign in to comment.