Skip to content

Commit

Permalink
wl1271: Release interrupt *after* releasing the driver context
Browse files Browse the repository at this point in the history 
The current order causes driver releasing to fail in various ways, and causes
possible instability.

Signed-off-by: Juuso Oikarinen <juuso.oikarinen@nokia.com>
Reviewed-by: Luciano Coelho <luciano.coelho@nokia.com>
Signed-off-by: Luciano Coelho <luciano.coelho@nokia.com>
  • Loading branch information
Juuso Oikarinen authored and Luciano Coelho committed Sep 28, 2010
1 parent 1655309 commit 4e23b11
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 4 deletions.
3 changes: 1 addition & 2 deletions drivers/net/wireless/wl12xx/wl1271_sdio.c
View file
Original file line number Diff line number Diff line change
Expand Up @@ -274,9 +274,8 @@ static void __devexit wl1271_remove(struct sdio_func *func)
{
struct wl1271 *wl = sdio_get_drvdata(func);

free_irq(wl->irq, wl);

wl1271_unregister_hw(wl);
free_irq(wl->irq, wl);
wl1271_free_hw(wl);
}

Expand Down
3 changes: 1 addition & 2 deletions drivers/net/wireless/wl12xx/wl1271_spi.c
View file
Original file line number Diff line number Diff line change
Expand Up @@ -416,9 +416,8 @@ static int __devexit wl1271_remove(struct spi_device *spi)
{
struct wl1271 *wl = dev_get_drvdata(&spi->dev);

free_irq(wl->irq, wl);

wl1271_unregister_hw(wl);
free_irq(wl->irq, wl);
wl1271_free_hw(wl);

return 0;
Expand Down

0 comments on commit 4e23b11

Please sign in to comment.