Skip to content

Commit

Permalink
bridge: use list_for_each_entry() in netpoll functions
Browse files Browse the repository at this point in the history
We don't delete 'p' from the list in the loop,
so we can just use list_for_each_entry().

Cc: David Miller <davem@davemloft.net>
Cc: Stephen Hemminger <shemminger@vyatta.com>
Signed-off-by: Cong Wang <amwang@redhat.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Amerigo Wang authored and David S. Miller committed Aug 14, 2012
1 parent d30362c commit 4e3828c
Showing 1 changed file with 4 additions and 5 deletions.
9 changes: 4 additions & 5 deletions net/bridge/br_device.c
Original file line number Diff line number Diff line change
Expand Up @@ -206,21 +206,20 @@ static void br_poll_controller(struct net_device *br_dev)
static void br_netpoll_cleanup(struct net_device *dev)
{
struct net_bridge *br = netdev_priv(dev);
struct net_bridge_port *p, *n;
struct net_bridge_port *p;

list_for_each_entry_safe(p, n, &br->port_list, list) {
list_for_each_entry(p, &br->port_list, list)
br_netpoll_disable(p);
}
}

static int br_netpoll_setup(struct net_device *dev, struct netpoll_info *ni,
gfp_t gfp)
{
struct net_bridge *br = netdev_priv(dev);
struct net_bridge_port *p, *n;
struct net_bridge_port *p;
int err = 0;

list_for_each_entry_safe(p, n, &br->port_list, list) {
list_for_each_entry(p, &br->port_list, list) {
if (!p->dev)
continue;
err = br_netpoll_enable(p, gfp);
Expand Down

0 comments on commit 4e3828c

Please sign in to comment.