Skip to content

Commit

Permalink
[ARM] Fix Versatile PB initialisation to use .init_machine
Browse files Browse the repository at this point in the history
There's no point having the Versatile PB initialisation using an
arch_initcall() and then checking whether it's running on a
Versatile PB board - this is what the .init_machine function
pointer in the machine description is for.  Use it.

Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
  • Loading branch information
Russell King authored and Russell King committed Nov 30, 2006
1 parent 1222144 commit 4e4e520
Showing 1 changed file with 7 additions and 11 deletions.
18 changes: 7 additions & 11 deletions arch/arm/mach-versatile/versatile_pb.c
Original file line number Diff line number Diff line change
Expand Up @@ -81,22 +81,18 @@ static struct amba_device *amba_devs[] __initdata = {
&mmc1_device,
};

static int __init versatile_pb_init(void)
static void __init versatile_pb_init(void)
{
int i;

if (machine_is_versatile_pb()) {
for (i = 0; i < ARRAY_SIZE(amba_devs); i++) {
struct amba_device *d = amba_devs[i];
amba_device_register(d, &iomem_resource);
}
}
versatile_init();

return 0;
for (i = 0; i < ARRAY_SIZE(amba_devs); i++) {
struct amba_device *d = amba_devs[i];
amba_device_register(d, &iomem_resource);
}
}

arch_initcall(versatile_pb_init);

MACHINE_START(VERSATILE_PB, "ARM-Versatile PB")
/* Maintainer: ARM Ltd/Deep Blue Solutions Ltd */
.phys_io = 0x101f1000,
Expand All @@ -105,5 +101,5 @@ MACHINE_START(VERSATILE_PB, "ARM-Versatile PB")
.map_io = versatile_map_io,
.init_irq = versatile_init_irq,
.timer = &versatile_timer,
.init_machine = versatile_init,
.init_machine = versatile_pb_init,
MACHINE_END

0 comments on commit 4e4e520

Please sign in to comment.