Skip to content

Commit

Permalink
[PATCH] quota: improve credits estimates
Browse files Browse the repository at this point in the history
Improve estimates on the number of needed credits for quota transaction.
Now we distinguish blocks that might need to be allocated and blocks that
only need to be rewritten.  Also we distinguish deleting of a quota
structure and creating of a new one.

Signed-off-by: Jan Kara <jack@suse.cz>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
  • Loading branch information
Jan Kara authored and Linus Torvalds committed Jun 24, 2005
1 parent bd6a1f1 commit 4e5117b
Show file tree
Hide file tree
Showing 3 changed files with 17 additions and 2 deletions.
6 changes: 6 additions & 0 deletions include/linux/dqblk_v1.h
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,12 @@
/* Root squash turned on */
#define V1_DQF_RSQUASH 1

/* Numbers of blocks needed for updates */
#define V1_INIT_ALLOC 1
#define V1_INIT_REWRITE 1
#define V1_DEL_ALLOC 0
#define V1_DEL_REWRITE 2

/* Special information about quotafile */
struct v1_mem_dqinfo {
};
Expand Down
6 changes: 6 additions & 0 deletions include/linux/dqblk_v2.h
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,12 @@
/* id numbers of quota format */
#define QFMT_VFS_V0 2

/* Numbers of blocks needed for updates */
#define V2_INIT_ALLOC 4
#define V2_INIT_REWRITE 2
#define V2_DEL_ALLOC 0
#define V2_DEL_REWRITE 6

/* Inmemory copy of version specific information */
struct v2_mem_dqinfo {
unsigned int dqi_blocks;
Expand Down
7 changes: 5 additions & 2 deletions include/linux/quota.h
Original file line number Diff line number Diff line change
Expand Up @@ -138,8 +138,11 @@ struct if_dqinfo {
#include <linux/dqblk_v2.h>

/* Maximal numbers of writes for quota operation (insert/delete/update)
* (over all formats) - info block, 4 pointer blocks, data block */
#define DQUOT_MAX_WRITES 6
* (over VFS all formats) */
#define DQUOT_INIT_ALLOC max(V1_INIT_ALLOC, V2_INIT_ALLOC)
#define DQUOT_INIT_REWRITE max(V1_INIT_REWRITE, V2_INIT_REWRITE)
#define DQUOT_DEL_ALLOC max(V1_DEL_ALLOC, V2_DEL_ALLOC)
#define DQUOT_DEL_REWRITE max(V1_DEL_REWRITE, V2_DEL_REWRITE)

/*
* Data for one user/group kept in memory
Expand Down

0 comments on commit 4e5117b

Please sign in to comment.