Skip to content

Commit

Permalink
aoe: print warning regarding a common reason for dropped transmits
Browse files Browse the repository at this point in the history
Dropped transmits are not common, but when they do occur, increasing
the transmit queue length often helps.

Signed-off-by: Ed Cashin <ecashin@coraid.com>
Cc: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
  • Loading branch information
Ed Cashin authored and Linus Torvalds committed Dec 18, 2012
1 parent 662a889 commit 4e78dd1
Showing 1 changed file with 7 additions and 2 deletions.
9 changes: 7 additions & 2 deletions drivers/block/aoe/aoenet.c
Original file line number Diff line number Diff line change
Expand Up @@ -52,13 +52,18 @@ static struct sk_buff_head skbtxq;

/* enters with txlock held */
static int
tx(void)
tx(void) __must_hold(&txlock)
{
struct sk_buff *skb;
struct net_device *ifp;

while ((skb = skb_dequeue(&skbtxq))) {
spin_unlock_irq(&txlock);
dev_queue_xmit(skb);
ifp = skb->dev;
if (dev_queue_xmit(skb) == NET_XMIT_DROP && net_ratelimit())
pr_warn("aoe: packet could not be sent on %s. %s\n",
ifp ? ifp->name : "netif",
"consider increasing tx_queue_len");
spin_lock_irq(&txlock);
}
return 0;
Expand Down

0 comments on commit 4e78dd1

Please sign in to comment.