Skip to content

Commit

Permalink
hfs: remove unnecessary dentry_unhash on rmdir, dir rename
Browse files Browse the repository at this point in the history
hfs does not have problems with references to unlinked directories.

Signed-off-by: Sage Weil <sage@newdream.net>
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
  • Loading branch information
Sage Weil authored and Al Viro committed May 28, 2011
1 parent 8aaa0f5 commit 4e82d61
Showing 1 changed file with 0 additions and 6 deletions.
6 changes: 0 additions & 6 deletions fs/hfs/dir.c
Original file line number Diff line number Diff line change
Expand Up @@ -253,9 +253,6 @@ static int hfs_remove(struct inode *dir, struct dentry *dentry)
struct inode *inode = dentry->d_inode;
int res;

if (S_ISDIR(inode->i_mode))
dentry_unhash(dentry);

if (S_ISDIR(inode->i_mode) && inode->i_size != 2)
return -ENOTEMPTY;
res = hfs_cat_delete(inode->i_ino, dir, &dentry->d_name);
Expand Down Expand Up @@ -286,9 +283,6 @@ static int hfs_rename(struct inode *old_dir, struct dentry *old_dentry,

/* Unlink destination if it already exists */
if (new_dentry->d_inode) {
if (S_ISDIR(new_dentry->d_inode->i_mode))
dentry_unhash(new_dentry);

res = hfs_remove(new_dir, new_dentry);
if (res)
return res;
Expand Down

0 comments on commit 4e82d61

Please sign in to comment.