Skip to content

Commit

Permalink
drm/i915: fix a sprite watermark computation to avoid divide by zero …
Browse files Browse the repository at this point in the history
…if xpos<0

When setting overlay position with x<0, it will divide 0 and make drm
driver crash.

Signed-off-by: Hai Lan <hai.lan@intel.com>
Signed-off-by: Jesse Barnes <jbarnes@virtuousgeek.org>
  • Loading branch information
Hai Lan authored and Jesse Barnes committed Feb 23, 2012
1 parent 5ca0c34 commit 4e9bb47
Showing 1 changed file with 9 additions and 0 deletions.
9 changes: 9 additions & 0 deletions drivers/gpu/drm/i915/intel_display.c
Original file line number Diff line number Diff line change
Expand Up @@ -4680,8 +4680,17 @@ sandybridge_compute_sprite_srwm(struct drm_device *dev, int plane,

crtc = intel_get_crtc_for_plane(dev, plane);
clock = crtc->mode.clock;
if (!clock) {
*sprite_wm = 0;
return false;
}

line_time_us = (sprite_width * 1000) / clock;
if (!line_time_us) {
*sprite_wm = 0;
return false;
}

line_count = (latency_ns / line_time_us + 1000) / 1000;
line_size = sprite_width * pixel_size;

Expand Down

0 comments on commit 4e9bb47

Please sign in to comment.