Skip to content

Commit

Permalink
[PATCH] Fix uninitialised spinlock in via-pmu-backlight code.
Browse files Browse the repository at this point in the history
The uninitialised pmu_backlight_lock causes the current Fedora test kernel
(which has spinlock debugging enabled) to panic on suspend.

This is suboptimal, so I fixed it.

Signed-off-by: David Woodhouse <dwmw2@infradead.org>
Acked-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Acked-by: Michael Hanselmann <linux-kernel@hansmi.ch>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
  • Loading branch information
David Woodhouse authored and Linus Torvalds committed Sep 29, 2006
1 parent 910067d commit 4efd587
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/macintosh/via-pmu-backlight.c
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
#define MAX_PMU_LEVEL 0xFF

static struct backlight_properties pmu_backlight_data;
static spinlock_t pmu_backlight_lock;
static DEFINE_SPINLOCK(pmu_backlight_lock);
static int sleeping;
static u8 bl_curve[FB_BACKLIGHT_LEVELS];

Expand Down

0 comments on commit 4efd587

Please sign in to comment.