Skip to content

Commit

Permalink
drivers/video/backlight/l4f00242t03.c: use gpio_request_one() to simp…
Browse files Browse the repository at this point in the history
…lify error handling

Using gpio_request_one can make the error handling simpler.

Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
Cc: Richard Purdie <rpurdie@rpsys.net>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
  • Loading branch information
Fabio Estevam authored and Linus Torvalds committed Nov 1, 2011
1 parent 0556dc3 commit 4f5a66b
Showing 1 changed file with 4 additions and 11 deletions.
15 changes: 4 additions & 11 deletions drivers/video/backlight/l4f00242t03.c
Original file line number Diff line number Diff line change
Expand Up @@ -171,29 +171,22 @@ static int __devinit l4f00242t03_probe(struct spi_device *spi)

priv->spi = spi;

ret = gpio_request(pdata->reset_gpio, "lcd l4f00242t03 reset");
ret = gpio_request_one(pdata->reset_gpio, GPIOF_OUT_INIT_HIGH,
"lcd l4f00242t03 reset");
if (ret) {
dev_err(&spi->dev,
"Unable to get the lcd l4f00242t03 reset gpio.\n");
goto err;
}

ret = gpio_direction_output(pdata->reset_gpio, 1);
if (ret)
goto err2;

ret = gpio_request(pdata->data_enable_gpio,
"lcd l4f00242t03 data enable");
ret = gpio_request_one(pdata->data_enable_gpio, GPIOF_OUT_INIT_LOW,
"lcd l4f00242t03 data enable");
if (ret) {
dev_err(&spi->dev,
"Unable to get the lcd l4f00242t03 data en gpio.\n");
goto err2;
}

ret = gpio_direction_output(pdata->data_enable_gpio, 0);
if (ret)
goto err3;

priv->io_reg = regulator_get(&spi->dev, "vdd");
if (IS_ERR(priv->io_reg)) {
dev_err(&spi->dev, "%s: Unable to get the IO regulator\n",
Expand Down

0 comments on commit 4f5a66b

Please sign in to comment.