Skip to content

Commit

Permalink
ethoc: fix function return type
Browse files Browse the repository at this point in the history
update_ethoc_tx_stats doesn't need to return anything so make its return
type void in order to avoid an unnecessary cast when the function is called.

Signed-off-by: Jonas Bonn <jonas@southpole.se>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Jonas Bonn authored and David S. Miller committed Nov 28, 2010
1 parent 8dac428 commit 4f64bcb
Showing 1 changed file with 2 additions and 3 deletions.
5 changes: 2 additions & 3 deletions drivers/net/ethoc.c
Original file line number Diff line number Diff line change
Expand Up @@ -462,7 +462,7 @@ static int ethoc_rx(struct net_device *dev, int limit)
return count;
}

static int ethoc_update_tx_stats(struct ethoc *dev, struct ethoc_bd *bd)
static void ethoc_update_tx_stats(struct ethoc *dev, struct ethoc_bd *bd)
{
struct net_device *netdev = dev->netdev;

Expand Down Expand Up @@ -492,7 +492,6 @@ static int ethoc_update_tx_stats(struct ethoc *dev, struct ethoc_bd *bd)
netdev->stats.collisions += (bd->stat >> 4) & 0xf;
netdev->stats.tx_bytes += bd->stat >> 16;
netdev->stats.tx_packets++;
return 0;
}

static int ethoc_tx(struct net_device *dev, int limit)
Expand Down Expand Up @@ -523,7 +522,7 @@ static int ethoc_tx(struct net_device *dev, int limit)
break;
}

(void)ethoc_update_tx_stats(priv, &bd);
ethoc_update_tx_stats(priv, &bd);
priv->dty_tx++;
}

Expand Down

0 comments on commit 4f64bcb

Please sign in to comment.