Skip to content

Commit

Permalink
staging/comedi: Use pr_ or dev_ printks in drivers/serial2002.c
Browse files Browse the repository at this point in the history
fixed below checkpatch warning.
- WARNING: Prefer netdev_err(netdev, ... then dev_err(dev, ... then pr_err(...  to printk(KERN_ERR ...

and added pr_fmt.

Signed-off-by: YAMANE Toshiaki <yamanetoshi@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  • Loading branch information
YAMANE Toshiaki authored and Greg Kroah-Hartman committed Oct 25, 2012
1 parent 2847ff5 commit 4f72b73
Showing 1 changed file with 4 additions and 2 deletions.
6 changes: 4 additions & 2 deletions drivers/staging/comedi/drivers/serial2002.c
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,8 @@ Status: in development
*/

#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt

#include "../comedidev.h"

#include <linux/delay.h>
Expand Down Expand Up @@ -272,7 +274,7 @@ static struct serial_data serial_read(struct file *f, int timeout)

length++;
if (data < 0) {
printk(KERN_ERR "serial2002 error\n");
pr_err("Failed to read serial.\n");
break;
} else if (data & 0x80) {
result.value = (result.value << 7) | (data & 0x7f);
Expand Down Expand Up @@ -346,7 +348,7 @@ static int serial_2002_open(struct comedi_device *dev)
devpriv->tty = filp_open(port, O_RDWR, 0);
if (IS_ERR(devpriv->tty)) {
result = (int)PTR_ERR(devpriv->tty);
printk(KERN_ERR "serial_2002: file open error = %d\n", result);
dev_err(dev->class_dev, "file open error = %d\n", result);
} else {
struct config_t {

Expand Down

0 comments on commit 4f72b73

Please sign in to comment.