Skip to content

Commit

Permalink
lockdep: Fix backtraces
Browse files Browse the repository at this point in the history
Truncate stupid -1 entries in backtraces.

Signed-off-by: Peter Zijlstra <a.p.zijlstra@chello.nl>
LKML-Reference: <1248096665.15751.8816.camel@twins>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
  • Loading branch information
Peter Zijlstra authored and Ingo Molnar committed Aug 2, 2009
1 parent bbfa262 commit 4f84f43
Showing 1 changed file with 11 additions and 1 deletion.
12 changes: 11 additions & 1 deletion kernel/lockdep.c
Original file line number Diff line number Diff line change
Expand Up @@ -367,11 +367,21 @@ static int save_trace(struct stack_trace *trace)

save_stack_trace(trace);

/*
* Some daft arches put -1 at the end to indicate its a full trace.
*
* <rant> this is buggy anyway, since it takes a whole extra entry so a
* complete trace that maxes out the entries provided will be reported
* as incomplete, friggin useless </rant>
*/
if (trace->entries[trace->nr_entries-1] == ULONG_MAX)
trace->nr_entries--;

trace->max_entries = trace->nr_entries;

nr_stack_trace_entries += trace->nr_entries;

if (nr_stack_trace_entries == MAX_STACK_TRACE_ENTRIES) {
if (nr_stack_trace_entries >= MAX_STACK_TRACE_ENTRIES-1) {
if (!debug_locks_off_graph_unlock())
return 0;

Expand Down

0 comments on commit 4f84f43

Please sign in to comment.