Skip to content

Commit

Permalink
i810: fix sparse warnings
Browse files Browse the repository at this point in the history
Fix this sparse warnings:

  drivers/video/i810/i810_accel.c:305:3: warning: returning void-valued expression
  drivers/video/i810/i810_accel.c:331:3: warning: returning void-valued expression
  drivers/video/i810/i810_accel.c:370:3: warning: returning void-valued expression

Signed-off-by: Hannes Eder <hannes@hanneseder.net>
Cc: Krzysztof Helt <krzysztof.h1@poczta.fm>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
  • Loading branch information
Hannes Eder authored and Linus Torvalds committed Jan 6, 2009
1 parent 27ec937 commit 4fa34cd
Showing 1 changed file with 12 additions and 6 deletions.
18 changes: 12 additions & 6 deletions drivers/video/i810/i810_accel.c
Original file line number Diff line number Diff line change
Expand Up @@ -301,8 +301,10 @@ void i810fb_fillrect(struct fb_info *info, const struct fb_fillrect *rect)
u32 dx, dy, width, height, dest, rop = 0, color = 0;

if (!info->var.accel_flags || par->dev_flags & LOCKUP ||
par->depth == 4)
return cfb_fillrect(info, rect);
par->depth == 4) {
cfb_fillrect(info, rect);
return;
}

if (par->depth == 1)
color = rect->color;
Expand All @@ -327,8 +329,10 @@ void i810fb_copyarea(struct fb_info *info, const struct fb_copyarea *region)
u32 sx, sy, dx, dy, pitch, width, height, src, dest, xdir;

if (!info->var.accel_flags || par->dev_flags & LOCKUP ||
par->depth == 4)
return cfb_copyarea(info, region);
par->depth == 4) {
cfb_copyarea(info, region);
return;
}

dx = region->dx * par->depth;
sx = region->sx * par->depth;
Expand Down Expand Up @@ -366,8 +370,10 @@ void i810fb_imageblit(struct fb_info *info, const struct fb_image *image)
u32 fg = 0, bg = 0, size, dst;

if (!info->var.accel_flags || par->dev_flags & LOCKUP ||
par->depth == 4 || image->depth != 1)
return cfb_imageblit(info, image);
par->depth == 4 || image->depth != 1) {
cfb_imageblit(info, image);
return;
}

switch (info->var.bits_per_pixel) {
case 8:
Expand Down

0 comments on commit 4fa34cd

Please sign in to comment.