Skip to content

Commit

Permalink
[PATCH] pcmcia: fix cross-platform issues with pcmcia module aliases
Browse files Browse the repository at this point in the history
- Added a missing TO_NATIVE call to scripts/mod/file2alias.c:do_pcmcia_entry()
- Add an alignment attribute to struct pcmcia_device_no to solve an alignment
  issue seen when cross-compiling on x86 for m68k.

Signed-off-by: Kars de Jong <jongk@linux-m68k.org>
Signed-off-by: Dominik Brodowski <linux@dominikbrodowski.net>
  • Loading branch information
Kars de Jong authored and Dominik Brodowski committed Sep 26, 2005
1 parent 2570b74 commit 4fb7edc
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 2 deletions.
5 changes: 3 additions & 2 deletions include/linux/mod_devicetable.h
Original file line number Diff line number Diff line change
Expand Up @@ -209,10 +209,11 @@ struct pcmcia_device_id {
/* for real multi-function devices */
__u8 function;

/* for pseude multi-function devices */
/* for pseudo multi-function devices */
__u8 device_no;

__u32 prod_id_hash[4];
__u32 prod_id_hash[4]
__attribute__((aligned(sizeof(__u32))));

/* not matched against in kernelspace*/
#ifdef __KERNEL__
Expand Down
2 changes: 2 additions & 0 deletions scripts/mod/file2alias.c
Original file line number Diff line number Diff line change
Expand Up @@ -295,11 +295,13 @@ static int do_pcmcia_entry(const char *filename,
{
unsigned int i;

id->match_flags = TO_NATIVE(id->match_flags);
id->manf_id = TO_NATIVE(id->manf_id);
id->card_id = TO_NATIVE(id->card_id);
id->func_id = TO_NATIVE(id->func_id);
id->function = TO_NATIVE(id->function);
id->device_no = TO_NATIVE(id->device_no);

for (i=0; i<4; i++) {
id->prod_id_hash[i] = TO_NATIVE(id->prod_id_hash[i]);
}
Expand Down

0 comments on commit 4fb7edc

Please sign in to comment.