Skip to content

Commit

Permalink
SUNRPC: Remove EXPORT_SYMBOL_GPL() from GSS mech switch
Browse files Browse the repository at this point in the history
Clean up: Reduce the symbol table footprint for auth_rpcgss.ko by
removing exported symbols for functions that are no longer used
outside of auth_rpcgss.ko.

The remaining two EXPORTs in gss_mech_switch.c get documenting
comments.

Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>
  • Loading branch information
Chuck Lever authored and Trond Myklebust committed Mar 29, 2013
1 parent 6599c0a commit 5007220
Showing 1 changed file with 13 additions and 13 deletions.
26 changes: 13 additions & 13 deletions net/sunrpc/auth_gss/gss_mech_switch.c
Original file line number Diff line number Diff line change
Expand Up @@ -103,8 +103,13 @@ gss_mech_svc_setup(struct gss_api_mech *gm)
return status;
}

int
gss_mech_register(struct gss_api_mech *gm)
/**
* gss_mech_register - register a GSS mechanism
* @gm: GSS mechanism handle
*
* Returns zero if successful, or a negative errno.
*/
int gss_mech_register(struct gss_api_mech *gm)
{
int status;

Expand All @@ -117,19 +122,21 @@ gss_mech_register(struct gss_api_mech *gm)
dprintk("RPC: registered gss mechanism %s\n", gm->gm_name);
return 0;
}

EXPORT_SYMBOL_GPL(gss_mech_register);

void
gss_mech_unregister(struct gss_api_mech *gm)
/**
* gss_mech_unregister - release a GSS mechanism
* @gm: GSS mechanism handle
*
*/
void gss_mech_unregister(struct gss_api_mech *gm)
{
spin_lock(&registered_mechs_lock);
list_del(&gm->gm_list);
spin_unlock(&registered_mechs_lock);
dprintk("RPC: unregistered gss mechanism %s\n", gm->gm_name);
gss_mech_free(gm);
}

EXPORT_SYMBOL_GPL(gss_mech_unregister);

static struct gss_api_mech *gss_mech_get(struct gss_api_mech *gm)
Expand Down Expand Up @@ -167,7 +174,6 @@ struct gss_api_mech * gss_mech_get_by_name(const char *name)
}
return gm;
}
EXPORT_SYMBOL_GPL(gss_mech_get_by_name);

static struct gss_api_mech *gss_mech_get_by_OID(struct rpcsec_gss_oid *obj)
{
Expand Down Expand Up @@ -355,8 +361,6 @@ gss_pseudoflavor_to_service(struct gss_api_mech *gm, u32 pseudoflavor)
return 0;
}

EXPORT_SYMBOL_GPL(gss_pseudoflavor_to_service);

char *
gss_service_to_auth_domain_name(struct gss_api_mech *gm, u32 service)
{
Expand All @@ -369,17 +373,13 @@ gss_service_to_auth_domain_name(struct gss_api_mech *gm, u32 service)
return NULL;
}

EXPORT_SYMBOL_GPL(gss_service_to_auth_domain_name);

void
gss_mech_put(struct gss_api_mech * gm)
{
if (gm)
module_put(gm->gm_owner);
}

EXPORT_SYMBOL_GPL(gss_mech_put);

/* The mech could probably be determined from the token instead, but it's just
* as easy for now to pass it in. */
int
Expand Down

0 comments on commit 5007220

Please sign in to comment.