Skip to content

Commit

Permalink
staging: sm7xxfb: erase hardcode cast between smtcfb_info and fb_info
Browse files Browse the repository at this point in the history
This patch erases hardcode cast between smtcfb_info and fb_info in order
to get a more robust and less rigid smtcfb_info structure. fb_info
doesn't need to be the first field in smtcfb_info after this patch.

Tested with SM712.

Signed-off-by: Javier M. Mellid <jmunhoz@igalia.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  • Loading branch information
Javier M. Mellid authored and Greg Kroah-Hartman committed Jul 6, 2012
1 parent 7813296 commit 501b02e
Showing 1 changed file with 5 additions and 5 deletions.
10 changes: 5 additions & 5 deletions drivers/staging/sm7xxfb/sm7xxfb.c
Original file line number Diff line number Diff line change
Expand Up @@ -40,8 +40,8 @@ struct screen_info smtc_screen_info;
* Private structure
*/
struct smtcfb_info {
struct fb_info fb;
struct pci_dev *pdev;
struct fb_info fb;
u16 chip_id;
u8 chip_rev_id;

Expand Down Expand Up @@ -328,9 +328,11 @@ static int smtc_blank(int blank_mode, struct fb_info *info)
static int smtc_setcolreg(unsigned regno, unsigned red, unsigned green,
unsigned blue, unsigned trans, struct fb_info *info)
{
struct smtcfb_info *sfb = (struct smtcfb_info *)info;
struct smtcfb_info *sfb;
u32 val;

sfb = info->par;

if (regno > 255)
return 1;

Expand Down Expand Up @@ -623,9 +625,7 @@ static int smtc_check_var(struct fb_var_screeninfo *var, struct fb_info *info)

static int smtc_set_par(struct fb_info *info)
{
struct smtcfb_info *sfb = (struct smtcfb_info *)info;

smtcfb_setmode(sfb);
smtcfb_setmode(info->par);

return 0;
}
Expand Down

0 comments on commit 501b02e

Please sign in to comment.