Skip to content

Commit

Permalink
---
Browse files Browse the repository at this point in the history
yaml
---
r: 260399
b: refs/heads/master
c: 1af8efe
h: refs/heads/master
i:
  260397: 3fbc47f
  260395: 72ad11c
  260391: b48386d
  260383: 5617fb1
v: v3
  • Loading branch information
Michal Hocko authored and Linus Torvalds committed Jul 26, 2011
1 parent 61da2bd commit 5086ca5
Show file tree
Hide file tree
Showing 2 changed files with 12 additions and 12 deletions.
2 changes: 1 addition & 1 deletion [refs]
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
---
refs/heads/master: 79dfdaccd1d5b40ff7cf4a35a0e63696ebb78b4d
refs/heads/master: 1af8efe965676ab30d6c8a5b1fccc9229f339a3b
22 changes: 11 additions & 11 deletions trunk/mm/memcontrol.c
Original file line number Diff line number Diff line change
Expand Up @@ -1725,7 +1725,7 @@ static int mem_cgroup_hierarchical_reclaim(struct mem_cgroup *root_mem,
/*
* Check OOM-Killer is already running under our hierarchy.
* If someone is running, return false.
* Has to be called with memcg_oom_mutex
* Has to be called with memcg_oom_lock
*/
static bool mem_cgroup_oom_lock(struct mem_cgroup *mem)
{
Expand Down Expand Up @@ -1770,7 +1770,7 @@ static bool mem_cgroup_oom_lock(struct mem_cgroup *mem)
}

/*
* Has to be called with memcg_oom_mutex
* Has to be called with memcg_oom_lock
*/
static int mem_cgroup_oom_unlock(struct mem_cgroup *mem)
{
Expand Down Expand Up @@ -1802,7 +1802,7 @@ static void mem_cgroup_unmark_under_oom(struct mem_cgroup *mem)
atomic_add_unless(&iter->under_oom, -1, 0);
}

static DEFINE_MUTEX(memcg_oom_mutex);
static DEFINE_SPINLOCK(memcg_oom_lock);
static DECLARE_WAIT_QUEUE_HEAD(memcg_oom_waitq);

struct oom_wait_info {
Expand Down Expand Up @@ -1864,7 +1864,7 @@ bool mem_cgroup_handle_oom(struct mem_cgroup *mem, gfp_t mask)
mem_cgroup_mark_under_oom(mem);

/* At first, try to OOM lock hierarchy under mem.*/
mutex_lock(&memcg_oom_mutex);
spin_lock(&memcg_oom_lock);
locked = mem_cgroup_oom_lock(mem);
/*
* Even if signal_pending(), we can't quit charge() loop without
Expand All @@ -1876,7 +1876,7 @@ bool mem_cgroup_handle_oom(struct mem_cgroup *mem, gfp_t mask)
need_to_kill = false;
if (locked)
mem_cgroup_oom_notify(mem);
mutex_unlock(&memcg_oom_mutex);
spin_unlock(&memcg_oom_lock);

if (need_to_kill) {
finish_wait(&memcg_oom_waitq, &owait.wait);
Expand All @@ -1885,11 +1885,11 @@ bool mem_cgroup_handle_oom(struct mem_cgroup *mem, gfp_t mask)
schedule();
finish_wait(&memcg_oom_waitq, &owait.wait);
}
mutex_lock(&memcg_oom_mutex);
spin_lock(&memcg_oom_lock);
if (locked)
mem_cgroup_oom_unlock(mem);
memcg_wakeup_oom(mem);
mutex_unlock(&memcg_oom_mutex);
spin_unlock(&memcg_oom_lock);

mem_cgroup_unmark_under_oom(mem);

Expand Down Expand Up @@ -4553,15 +4553,15 @@ static int mem_cgroup_oom_register_event(struct cgroup *cgrp,
if (!event)
return -ENOMEM;

mutex_lock(&memcg_oom_mutex);
spin_lock(&memcg_oom_lock);

event->eventfd = eventfd;
list_add(&event->list, &memcg->oom_notify);

/* already in OOM ? */
if (atomic_read(&memcg->under_oom))
eventfd_signal(eventfd, 1);
mutex_unlock(&memcg_oom_mutex);
spin_unlock(&memcg_oom_lock);

return 0;
}
Expand All @@ -4575,7 +4575,7 @@ static void mem_cgroup_oom_unregister_event(struct cgroup *cgrp,

BUG_ON(type != _OOM_TYPE);

mutex_lock(&memcg_oom_mutex);
spin_lock(&memcg_oom_lock);

list_for_each_entry_safe(ev, tmp, &mem->oom_notify, list) {
if (ev->eventfd == eventfd) {
Expand All @@ -4584,7 +4584,7 @@ static void mem_cgroup_oom_unregister_event(struct cgroup *cgrp,
}
}

mutex_unlock(&memcg_oom_mutex);
spin_unlock(&memcg_oom_lock);
}

static int mem_cgroup_oom_control_read(struct cgroup *cgrp,
Expand Down

0 comments on commit 5086ca5

Please sign in to comment.