Skip to content

Commit

Permalink
mm: fewer underscores in ____pagevec_lru_add
Browse files Browse the repository at this point in the history
What's so special about ____pagevec_lru_add() that it needs four leading
underscores?  Nothing, it just helped to distinguish from
__pagevec_lru_add() in 2.6.28 development.  Cut two leading underscores.

Signed-off-by: Hugh Dickins <hughd@google.com>
Reviewed-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
  • Loading branch information
Hugh Dickins authored and Linus Torvalds committed Jan 13, 2012
1 parent 2bcf887 commit 5095ae8
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 11 deletions.
10 changes: 5 additions & 5 deletions include/linux/pagevec.h
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ struct pagevec {
};

void __pagevec_release(struct pagevec *pvec);
void ____pagevec_lru_add(struct pagevec *pvec, enum lru_list lru);
void __pagevec_lru_add(struct pagevec *pvec, enum lru_list lru);
unsigned pagevec_lookup(struct pagevec *pvec, struct address_space *mapping,
pgoff_t start, unsigned nr_pages);
unsigned pagevec_lookup_tag(struct pagevec *pvec,
Expand Down Expand Up @@ -66,22 +66,22 @@ static inline void pagevec_release(struct pagevec *pvec)

static inline void __pagevec_lru_add_anon(struct pagevec *pvec)
{
____pagevec_lru_add(pvec, LRU_INACTIVE_ANON);
__pagevec_lru_add(pvec, LRU_INACTIVE_ANON);
}

static inline void __pagevec_lru_add_active_anon(struct pagevec *pvec)
{
____pagevec_lru_add(pvec, LRU_ACTIVE_ANON);
__pagevec_lru_add(pvec, LRU_ACTIVE_ANON);
}

static inline void __pagevec_lru_add_file(struct pagevec *pvec)
{
____pagevec_lru_add(pvec, LRU_INACTIVE_FILE);
__pagevec_lru_add(pvec, LRU_INACTIVE_FILE);
}

static inline void __pagevec_lru_add_active_file(struct pagevec *pvec)
{
____pagevec_lru_add(pvec, LRU_ACTIVE_FILE);
__pagevec_lru_add(pvec, LRU_ACTIVE_FILE);
}

static inline void pagevec_lru_add_file(struct pagevec *pvec)
Expand Down
12 changes: 6 additions & 6 deletions mm/swap.c
Original file line number Diff line number Diff line change
Expand Up @@ -378,7 +378,7 @@ void __lru_cache_add(struct page *page, enum lru_list lru)

page_cache_get(page);
if (!pagevec_add(pvec, page))
____pagevec_lru_add(pvec, lru);
__pagevec_lru_add(pvec, lru);
put_cpu_var(lru_add_pvecs);
}
EXPORT_SYMBOL(__lru_cache_add);
Expand Down Expand Up @@ -506,7 +506,7 @@ static void drain_cpu_pagevecs(int cpu)
for_each_lru(lru) {
pvec = &pvecs[lru - LRU_BASE];
if (pagevec_count(pvec))
____pagevec_lru_add(pvec, lru);
__pagevec_lru_add(pvec, lru);
}

pvec = &per_cpu(lru_rotate_pvecs, cpu);
Expand Down Expand Up @@ -698,7 +698,7 @@ void lru_add_page_tail(struct zone* zone,
}
#endif /* CONFIG_TRANSPARENT_HUGEPAGE */

static void ____pagevec_lru_add_fn(struct page *page, void *arg)
static void __pagevec_lru_add_fn(struct page *page, void *arg)
{
enum lru_list lru = (enum lru_list)arg;
struct zone *zone = page_zone(page);
Expand All @@ -720,14 +720,14 @@ static void ____pagevec_lru_add_fn(struct page *page, void *arg)
* Add the passed pages to the LRU, then drop the caller's refcount
* on them. Reinitialises the caller's pagevec.
*/
void ____pagevec_lru_add(struct pagevec *pvec, enum lru_list lru)
void __pagevec_lru_add(struct pagevec *pvec, enum lru_list lru)
{
VM_BUG_ON(is_unevictable_lru(lru));

pagevec_lru_move_fn(pvec, ____pagevec_lru_add_fn, (void *)lru);
pagevec_lru_move_fn(pvec, __pagevec_lru_add_fn, (void *)lru);
}

EXPORT_SYMBOL(____pagevec_lru_add);
EXPORT_SYMBOL(__pagevec_lru_add);

/**
* pagevec_lookup - gang pagecache lookup
Expand Down

0 comments on commit 5095ae8

Please sign in to comment.