Skip to content

Commit

Permalink
[media] gspca: dubious one-bit signed bitfield
Browse files Browse the repository at this point in the history
This patch changes some signed integers to unsigned because
they are not intended for negative values and sparse
is making noise about it.

Sparse gives eight of these errors:
drivers/media/usb/gspca/ov519.c:144:29: error: dubious one-bit signed bitfield

Signed-off-by: Emil Goode <emilgoode@gmail.com>
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
  • Loading branch information
Emil Goode authored and Mauro Carvalho Chehab committed Sep 13, 2012
1 parent 4a7ec2d commit 50c457a
Showing 1 changed file with 8 additions and 8 deletions.
16 changes: 8 additions & 8 deletions drivers/media/usb/gspca/ov519.c
Original file line number Diff line number Diff line change
Expand Up @@ -141,14 +141,14 @@ enum sensors {

/* table of the disabled controls */
struct ctrl_valid {
int has_brightness:1;
int has_contrast:1;
int has_exposure:1;
int has_autogain:1;
int has_sat:1;
int has_hvflip:1;
int has_autobright:1;
int has_freq:1;
unsigned int has_brightness:1;
unsigned int has_contrast:1;
unsigned int has_exposure:1;
unsigned int has_autogain:1;
unsigned int has_sat:1;
unsigned int has_hvflip:1;
unsigned int has_autobright:1;
unsigned int has_freq:1;
};

static const struct ctrl_valid valid_controls[] = {
Expand Down

0 comments on commit 50c457a

Please sign in to comment.