Skip to content

Commit

Permalink
V4L/DVB (7733): blackbird_find_mailbox negative return ignored in bla…
Browse files Browse the repository at this point in the history
…ckbird_initialize_codec()

dev->mailbox is unsigned. so a negative return goes unnoticed

Signed-off-by: Roel Kluin <12o3l@tiscali.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org>
  • Loading branch information
Roel Kluin authored and Mauro Carvalho Chehab committed Apr 26, 2008
1 parent 63b79cf commit 50fa46b
Showing 1 changed file with 4 additions and 2 deletions.
6 changes: 4 additions & 2 deletions drivers/media/video/cx88/cx88-blackbird.c
Original file line number Diff line number Diff line change
Expand Up @@ -546,10 +546,12 @@ static int blackbird_initialize_codec(struct cx8802_dev *dev)
if (retval < 0)
return retval;

dev->mailbox = blackbird_find_mailbox(dev);
if (dev->mailbox < 0)
retval = blackbird_find_mailbox(dev);
if (retval < 0)
return -1;

dev->mailbox = retval;

retval = blackbird_api_cmd(dev, CX2341X_ENC_PING_FW, 0, 0); /* ping */
if (retval < 0) {
dprintk(0, "ERROR: Firmware ping failed!\n");
Expand Down

0 comments on commit 50fa46b

Please sign in to comment.