Skip to content

Commit

Permalink
---
Browse files Browse the repository at this point in the history
yaml
---
r: 325683
b: refs/heads/master
c: 10c6c38
h: refs/heads/master
i:
  325681: 838aa39
  325679: 95bb92c
v: v3
  • Loading branch information
samix.lebsir authored and Greg Kroah-Hartman committed Aug 16, 2012
1 parent 6697a97 commit 511ec47
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 25 deletions.
2 changes: 1 addition & 1 deletion [refs]
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
---
refs/heads/master: c01af4fec2c8f303d6b3354d44308d9e6bef8026
refs/heads/master: 10c6c383e43565c9c6ec07ff8eb2825f8091bdf0
25 changes: 1 addition & 24 deletions trunk/drivers/tty/n_gsm.c
Original file line number Diff line number Diff line change
Expand Up @@ -691,10 +691,6 @@ static void gsm_data_kick(struct gsm_mux *gsm)
msg = msg->next;
continue;
}
if (gsm->dlci[msg->addr]->constipated) {
msg = msg->next;
continue;
}
if (gsm->encoding != 0) {
gsm->txframe[0] = GSM1_SOF;
len = gsm_stuff_frame(msg->data,
Expand Down Expand Up @@ -748,8 +744,6 @@ static void __gsm_data_queue(struct gsm_dlci *dlci, struct gsm_msg *msg)
u8 *dp = msg->data;
u8 *fcs = dp + msg->len;

WARN_ONCE(dlci->constipated, "%s: queueing from a constipated DLCI",
__func__);
/* Fill in the header */
if (gsm->encoding == 0) {
if (msg->len < 128)
Expand Down Expand Up @@ -956,9 +950,6 @@ static void gsm_dlci_data_sweep(struct gsm_mux *gsm)
break;
dlci = gsm->dlci[i];
if (dlci == NULL || dlci->constipated) {
if (dlci && (debug & 0x20))
pr_info("%s: DLCI %d is constipated",
__func__, i);
i++;
continue;
}
Expand Down Expand Up @@ -988,12 +979,8 @@ static void gsm_dlci_data_kick(struct gsm_dlci *dlci)
unsigned long flags;
int sweep;

if (dlci->constipated) {
if (debug & 0x20)
pr_info("%s: DLCI %d is constipated",
__func__, dlci->addr);
if (dlci->constipated)
return;
}

spin_lock_irqsave(&dlci->gsm->tx_lock, flags);
/* If we have nothing running then we need to fire up */
Expand Down Expand Up @@ -1069,15 +1056,9 @@ static void gsm_process_modem(struct tty_struct *tty, struct gsm_dlci *dlci,
/* Flow control/ready to communicate */
fc = (modem & MDM_FC) || !(modem & MDM_RTR);
if (fc && !dlci->constipated) {
if (debug & 0x20)
pr_info("%s: DLCI %d START constipated (tx_bytes=%d)",
__func__, dlci->addr, dlci->gsm->tx_bytes);
/* Need to throttle our output on this device */
dlci->constipated = 1;
} else if (!fc && dlci->constipated) {
if (debug & 0x20)
pr_info("%s: DLCI %d END constipated (tx_bytes=%d)",
__func__, dlci->addr, dlci->gsm->tx_bytes);
dlci->constipated = 0;
gsm_dlci_data_kick(dlci);
}
Expand Down Expand Up @@ -1241,17 +1222,13 @@ static void gsm_control_message(struct gsm_mux *gsm, unsigned int command,
break;
case CMD_FCON:
/* Modem can accept data again */
if (debug & 0x20)
pr_info("%s: GSM END constipation", __func__);
gsm->constipated = 0;
gsm_control_reply(gsm, CMD_FCON, NULL, 0);
/* Kick the link in case it is idling */
gsm_data_kick(gsm);
break;
case CMD_FCOFF:
/* Modem wants us to STFU */
if (debug & 0x20)
pr_info("%s: GSM START constipation", __func__);
gsm->constipated = 1;
gsm_control_reply(gsm, CMD_FCOFF, NULL, 0);
break;
Expand Down

0 comments on commit 511ec47

Please sign in to comment.