Skip to content

Commit

Permalink
DM9000: Update retry count whilst identifying chip
Browse files Browse the repository at this point in the history
Reading the ID register does not always return the correct ID
from the device, so we retry several times to see if we get
a correct value.

These failures seem to be excaserbated by the speed of the
access to the chip (possibly time between issuing the address
and then the data cycle).

Signed-off-by: Ben Dooks <ben-linux@fluff.org>
Signed-off-by: Jeff Garzik <jeff@garzik.org>
  • Loading branch information
Ben Dooks authored and Jeff Garzik committed Feb 11, 2008
1 parent f42d8ae commit 513b6be
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/net/dm9000.c
Original file line number Diff line number Diff line change
Expand Up @@ -643,7 +643,7 @@ dm9000_probe(struct platform_device *pdev)
dm9000_reset(db);

/* try two times, DM9000 sometimes gets the first read wrong */
for (i = 0; i < 2; i++) {
for (i = 0; i < 8; i++) {
id_val = ior(db, DM9000_VIDL);
id_val |= (u32)ior(db, DM9000_VIDH) << 8;
id_val |= (u32)ior(db, DM9000_PIDL) << 16;
Expand Down

0 comments on commit 513b6be

Please sign in to comment.