Skip to content

Commit

Permalink
dlm-user: BKL pushdown
Browse files Browse the repository at this point in the history
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
  • Loading branch information
Arnd Bergmann authored and Jonathan Corbet committed Jun 20, 2008
1 parent 009228d commit 514bcc6
Showing 1 changed file with 8 additions and 1 deletion.
9 changes: 8 additions & 1 deletion fs/dlm/user.c
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@
#include <linux/poll.h>
#include <linux/signal.h>
#include <linux/spinlock.h>
#include <linux/smp_lock.h>
#include <linux/dlm.h>
#include <linux/dlm_device.h>

Expand Down Expand Up @@ -618,13 +619,17 @@ static int device_open(struct inode *inode, struct file *file)
struct dlm_user_proc *proc;
struct dlm_ls *ls;

lock_kernel();
ls = dlm_find_lockspace_device(iminor(inode));
if (!ls)
if (!ls) {
unlock_kernel();
return -ENOENT;
}

proc = kzalloc(sizeof(struct dlm_user_proc), GFP_KERNEL);
if (!proc) {
dlm_put_lockspace(ls);
unlock_kernel();
return -ENOMEM;
}

Expand All @@ -636,6 +641,7 @@ static int device_open(struct inode *inode, struct file *file)
spin_lock_init(&proc->locks_spin);
init_waitqueue_head(&proc->wait);
file->private_data = proc;
unlock_kernel();

return 0;
}
Expand Down Expand Up @@ -870,6 +876,7 @@ static unsigned int device_poll(struct file *file, poll_table *wait)

static int ctl_device_open(struct inode *inode, struct file *file)
{
cycle_kernel_lock();
file->private_data = NULL;
return 0;
}
Expand Down

0 comments on commit 514bcc6

Please sign in to comment.