Skip to content

Commit

Permalink
---
Browse files Browse the repository at this point in the history
yaml
---
r: 247280
b: refs/heads/master
c: 2245090
h: refs/heads/master
v: v3
  • Loading branch information
Stanislaw Gruszka authored and John W. Linville committed Apr 29, 2011
1 parent 75b3b59 commit 51908ef
Show file tree
Hide file tree
Showing 5 changed files with 3 additions and 6 deletions.
2 changes: 1 addition & 1 deletion [refs]
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
---
refs/heads/master: 28a6e577c65cc317fed5265efc43ce9282928bd4
refs/heads/master: 22450902e4a13479acf6f4e93475af7ca1829d92
1 change: 0 additions & 1 deletion trunk/drivers/net/wireless/iwlegacy/iwl-dev.h
Original file line number Diff line number Diff line change
Expand Up @@ -1077,7 +1077,6 @@ struct iwl_priv {
spinlock_t hcmd_lock; /* protect hcmd */
spinlock_t reg_lock; /* protect hw register access */
struct mutex mutex;
struct mutex sync_cmd_mutex; /* enable serialization of sync commands */

/* basic pci-network driver stuff */
struct pci_dev *pci_dev;
Expand Down
4 changes: 2 additions & 2 deletions trunk/drivers/net/wireless/iwlegacy/iwl-hcmd.c
Original file line number Diff line number Diff line change
Expand Up @@ -145,14 +145,15 @@ int iwl_legacy_send_cmd_sync(struct iwl_priv *priv, struct iwl_host_cmd *cmd)
int cmd_idx;
int ret;

lockdep_assert_held(&priv->mutex);

BUG_ON(cmd->flags & CMD_ASYNC);

/* A synchronous command can not have a callback set. */
BUG_ON(cmd->callback);

IWL_DEBUG_INFO(priv, "Attempting to send sync command %s\n",
iwl_legacy_get_cmd_string(cmd->id));
mutex_lock(&priv->sync_cmd_mutex);

set_bit(STATUS_HCMD_ACTIVE, &priv->status);
IWL_DEBUG_INFO(priv, "Setting HCMD_ACTIVE for command %s\n",
Expand Down Expand Up @@ -224,7 +225,6 @@ int iwl_legacy_send_cmd_sync(struct iwl_priv *priv, struct iwl_host_cmd *cmd)
cmd->reply_page = 0;
}
out:
mutex_unlock(&priv->sync_cmd_mutex);
return ret;
}
EXPORT_SYMBOL(iwl_legacy_send_cmd_sync);
Expand Down
1 change: 0 additions & 1 deletion trunk/drivers/net/wireless/iwlegacy/iwl3945-base.c
Original file line number Diff line number Diff line change
Expand Up @@ -3815,7 +3815,6 @@ static int iwl3945_init_drv(struct iwl_priv *priv)
INIT_LIST_HEAD(&priv->free_frames);

mutex_init(&priv->mutex);
mutex_init(&priv->sync_cmd_mutex);

priv->ieee_channels = NULL;
priv->ieee_rates = NULL;
Expand Down
1 change: 0 additions & 1 deletion trunk/drivers/net/wireless/iwlegacy/iwl4965-base.c
Original file line number Diff line number Diff line change
Expand Up @@ -3124,7 +3124,6 @@ static int iwl4965_init_drv(struct iwl_priv *priv)
INIT_LIST_HEAD(&priv->free_frames);

mutex_init(&priv->mutex);
mutex_init(&priv->sync_cmd_mutex);

priv->ieee_channels = NULL;
priv->ieee_rates = NULL;
Expand Down

0 comments on commit 51908ef

Please sign in to comment.