Skip to content

Commit

Permalink
mac80211: Fix one more call to synchronize_rcu in atomic context.
Browse files Browse the repository at this point in the history
(This set applies OK without the previous one of 4 patches,
 but with some fuzz in the 7th one)

The mesh_path_node_free() does so under hashwlock.

But, this one is called
1. from mesh_path_add() after an old hash is hidden and
   synchronize_rcu() is calld
2. mesh_pathtbl_unregister(), when the module is being
   unloaded and no devices exist to mess with this hash.

So, it seems to me, that simply removing the call is OK.

Signed-off-by: Pavel Emelyanov <xemul@openvz.org>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
  • Loading branch information
Pavel Emelyanov authored and John W. Linville committed May 22, 2008
1 parent 402d775 commit 5194ee8
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion net/mac80211/mesh_pathtbl.c
Original file line number Diff line number Diff line change
Expand Up @@ -458,7 +458,6 @@ static void mesh_path_node_free(struct hlist_node *p, bool free_leafs)
struct mpath_node *node = hlist_entry(p, struct mpath_node, list);
mpath = node->mpath;
hlist_del_rcu(p);
synchronize_rcu();
if (free_leafs)
kfree(mpath);
kfree(node);
Expand Down

0 comments on commit 5194ee8

Please sign in to comment.