Skip to content

Commit

Permalink
ALSA: hda - CX20549 doesn't need pin_amp_workaround.
Browse files Browse the repository at this point in the history
CX20549 (ctx5045) doesn't accept data on index 1 for output pins,
as shown in the following hda-var transaction:

  $ hda-verb /dev/snd/hwC0D0 0x10 set_amp_gain 0xb126
  nid = 0x10, verb = 0x300, param = 0xb126
  value = 0x0
  $ hda-verb /dev/snd/hwC0D0 0x10 get_amp_gain 0x8001
  nid = 0x10, verb = 0xb00, param = 0x8001
  value = 0x0

Signed-off-by: Michael Karcher <kernel@mkarcher.dialup.fu-berlin.de>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
  • Loading branch information
Michael Karcher authored and Takashi Iwai committed Apr 7, 2012
1 parent e6e03da commit 51969d6
Showing 1 changed file with 3 additions and 2 deletions.
5 changes: 3 additions & 2 deletions sound/pci/hda/patch_conexant.c
Original file line number Diff line number Diff line change
Expand Up @@ -1086,7 +1086,6 @@ static int patch_cxt5045(struct hda_codec *codec)
if (!spec)
return -ENOMEM;
codec->spec = spec;
codec->pin_amp_workaround = 1;
codec->single_adc_amp = 1;

spec->multiout.max_channels = 2;
Expand Down Expand Up @@ -4443,15 +4442,17 @@ static int patch_conexant_auto(struct hda_codec *codec)
if (!spec)
return -ENOMEM;
codec->spec = spec;
codec->pin_amp_workaround = 1;

switch (codec->vendor_id) {
case 0x14f15045:
codec->single_adc_amp = 1;
break;
case 0x14f15051:
add_cx5051_fake_mutes(codec);
codec->pin_amp_workaround = 1;
break;
default:
codec->pin_amp_workaround = 1;
}

apply_pin_fixup(codec, cxt_fixups, cxt_pincfg_tbl);
Expand Down

0 comments on commit 51969d6

Please sign in to comment.