Skip to content

Commit

Permalink
Merge branch 'leds-fixes-3.10' of git://git.kernel.org/pub/scm/linux/…
Browse files Browse the repository at this point in the history
…kernel/git/cooloney/linux-leds

Pull LED subsystem fix from Bryan Wu.

* 'leds-fixes-3.10' of git://git.kernel.org/pub/scm/linux/kernel/git/cooloney/linux-leds:
  leds: leds-gpio: reserve gpio before using it
  • Loading branch information
Linus Torvalds committed May 21, 2013
2 parents e748a38 + 803d19d commit 519fe2e
Showing 1 changed file with 5 additions and 4 deletions.
9 changes: 5 additions & 4 deletions drivers/leds/leds-gpio.c
Original file line number Diff line number Diff line change
Expand Up @@ -107,6 +107,10 @@ static int create_gpio_led(const struct gpio_led *template,
return 0;
}

ret = devm_gpio_request(parent, template->gpio, template->name);
if (ret < 0)
return ret;

led_dat->cdev.name = template->name;
led_dat->cdev.default_trigger = template->default_trigger;
led_dat->gpio = template->gpio;
Expand All @@ -126,10 +130,7 @@ static int create_gpio_led(const struct gpio_led *template,
if (!template->retain_state_suspended)
led_dat->cdev.flags |= LED_CORE_SUSPENDRESUME;

ret = devm_gpio_request_one(parent, template->gpio,
(led_dat->active_low ^ state) ?
GPIOF_OUT_INIT_HIGH : GPIOF_OUT_INIT_LOW,
template->name);
ret = gpio_direction_output(led_dat->gpio, led_dat->active_low ^ state);
if (ret < 0)
return ret;

Expand Down

0 comments on commit 519fe2e

Please sign in to comment.