Skip to content

Commit

Permalink
Bug Fix arch/ia64/kernel/pci-dma.c: fix recursive dma_supported() cal…
Browse files Browse the repository at this point in the history
…l in iommu_dma_supported()

In commit 160c1d8,
dma_ops->dma_supported = iommu_dma_supported;

This dma_ops->dma_supported is first called in platform_dma_init() during kernel
boot. Then dma_ops->dma_supported will be called recursively in
iommu_dma_supported.

Kernel can not boot because kernel can not get out of iommu_dma_supported until
it runs out of stack memory.

Signed-off-by: Fenghua Yu <fenghua.yu@intel.com>
  • Loading branch information
Fenghua Yu authored and Fenghua Yu committed Aug 11, 2009
1 parent 85dfd81 commit 51b89f7
Showing 1 changed file with 0 additions and 5 deletions.
5 changes: 0 additions & 5 deletions arch/ia64/kernel/pci-dma.c
Original file line number Diff line number Diff line change
Expand Up @@ -69,11 +69,6 @@ iommu_dma_init(void)

int iommu_dma_supported(struct device *dev, u64 mask)
{
struct dma_map_ops *ops = platform_dma_get_ops(dev);

if (ops->dma_supported)
return ops->dma_supported(dev, mask);

/* Copied from i386. Doesn't make much sense, because it will
only work for pci_alloc_coherent.
The caller just has to use GFP_DMA in this case. */
Expand Down

0 comments on commit 51b89f7

Please sign in to comment.