Skip to content

Commit

Permalink
9p: remove 9p fcall debug prints
Browse files Browse the repository at this point in the history
One of the current debug options allows users to get a verbose dump of fcalls.
This isn't really necessary as correctly parsed protocol frames can be printed
as part of the code in the client functions.  The consolidated printfcalls
structure would require new entries to be added for every extension.  This
patch removes the debug print methods and their use.

Signed-off-by: Eric Van Hensbergen <ericvh@gmail.com>
  • Loading branch information
Eric Van Hensbergen committed Oct 17, 2008
1 parent ace51c4 commit 51d71f9
Show file tree
Hide file tree
Showing 5 changed files with 0 additions and 386 deletions.
1 change: 0 additions & 1 deletion include/net/9p/9p.h
Original file line number Diff line number Diff line change
Expand Up @@ -590,7 +590,6 @@ struct p9_fcall *p9_create_tstat(u32 fid);
struct p9_fcall *p9_create_twstat(u32 fid, struct p9_wstat *wstat,
int dotu);

int p9_printfcall(char *buf, int buflen, struct p9_fcall *fc, int dotu);
int p9_errstr2errno(char *errstr, int len);

struct p9_idpool *p9_idpool_create(void);
Expand Down
1 change: 0 additions & 1 deletion net/9p/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@ obj-$(CONFIG_NET_9P_VIRTIO) += 9pnet_virtio.o
client.o \
conv.o \
error.o \
fcprint.o \
util.o \
protocol.o \
trans_fd.o \
Expand Down
9 changes: 0 additions & 9 deletions net/9p/client.c
Original file line number Diff line number Diff line change
Expand Up @@ -502,15 +502,6 @@ p9_client_rpc(struct p9_client *c, struct p9_fcall *tc, struct p9_fcall **rc)
goto reterr;
}

#ifdef CONFIG_NET_9P_DEBUG
if ((p9_debug_level&P9_DEBUG_FCALL) == P9_DEBUG_FCALL) {
char buf[150];

p9_printfcall(buf, sizeof(buf), req->rc, c->dotu);
printk(KERN_NOTICE ">>> %p %s\n", c, buf);
}
#endif

if (req->rc->id == P9_RERROR) {
int ecode = req->rc->params.rerror.errno;
struct p9_str *ename = &req->rc->params.rerror.error;
Expand Down
366 changes: 0 additions & 366 deletions net/9p/fcprint.c

This file was deleted.

Loading

0 comments on commit 51d71f9

Please sign in to comment.