Skip to content

Commit

Permalink
---
Browse files Browse the repository at this point in the history
yaml
---
r: 215294
b: refs/heads/master
c: 15943a7
h: refs/heads/master
v: v3
  • Loading branch information
Christian Lamparter authored and John W. Linville committed Oct 11, 2010
1 parent 7d22690 commit 51f2f6f
Show file tree
Hide file tree
Showing 2 changed files with 25 additions and 1 deletion.
2 changes: 1 addition & 1 deletion [refs]
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
---
refs/heads/master: d12c74528e3065c90df70fbc06ec6ffd6e804738
refs/heads/master: 15943a72c7d2031c9150917ca9161a9f891d455a
24 changes: 24 additions & 0 deletions trunk/net/mac80211/rx.c
Original file line number Diff line number Diff line change
Expand Up @@ -622,6 +622,26 @@ static void ieee80211_sta_reorder_release(struct ieee80211_hw *hw,
tid_agg_rx->buf_size;
}

/*
* Disable the reorder release timer for now.
*
* The current implementation lacks a proper locking scheme
* which would protect vital statistic and debug counters
* from being updated by two different but concurrent BHs.
*
* More information about the topic is available from:
* - thread: http://marc.info/?t=128635927000001
*
* What was wrong:
* => http://marc.info/?l=linux-wireless&m=128636170811964
* "Basically the thing is that until your patch, the data
* in the struct didn't actually need locking because it
* was accessed by the RX path only which is not concurrent."
*
* List of what needs to be fixed:
* => http://marc.info/?l=linux-wireless&m=128656352920957
*
if (tid_agg_rx->stored_mpdu_num) {
j = index = seq_sub(tid_agg_rx->head_seq_num,
tid_agg_rx->ssn) % tid_agg_rx->buf_size;
Expand All @@ -640,6 +660,10 @@ static void ieee80211_sta_reorder_release(struct ieee80211_hw *hw,
} else {
del_timer(&tid_agg_rx->reorder_timer);
}
*/

set_release_timer:
return;
}

/*
Expand Down

0 comments on commit 51f2f6f

Please sign in to comment.