Skip to content

Commit

Permalink
p54: use IEEE 802.11e defaults for initialization
Browse files Browse the repository at this point in the history
This trival one-liner changes the QoS initialization values to match IEEE
802.11e defaults.

Signed-off-by: Christian Lamparter <chunkeey@web.de>
Acked-by: Johannes Berg <johannes@sipsolutions.net>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
  • Loading branch information
Christian Lamparter authored and John W. Linville committed Feb 29, 2008
1 parent 2c1a1b1 commit 5200e8c
Showing 1 changed file with 1 addition and 7 deletions.
8 changes: 1 addition & 7 deletions drivers/net/wireless/p54common.c
Original file line number Diff line number Diff line change
Expand Up @@ -782,15 +782,9 @@ static void p54_init_vdcf(struct ieee80211_hw *dev)

vdcf = (struct p54_tx_control_vdcf *) hdr->data;

/*
* FIXME: The default values in the spec (IEEE 802.11
* 7.3.2.19 Table 37) are 47, 94, 0, 0, why use
* 47, 94, 63, 0 here? Also, the default AIFS
* values (second parameter) are 2, 2, 3, 7...
*/
P54_SET_QUEUE(vdcf->queue[0], 0x0002, 0x0003, 0x0007, 47);
P54_SET_QUEUE(vdcf->queue[1], 0x0002, 0x0007, 0x000f, 94);
P54_SET_QUEUE(vdcf->queue[2], 0x0002, 0x000f, 0x03ff, 63);
P54_SET_QUEUE(vdcf->queue[2], 0x0003, 0x000f, 0x03ff, 0);
P54_SET_QUEUE(vdcf->queue[3], 0x0007, 0x000f, 0x03ff, 0);
}

Expand Down

0 comments on commit 5200e8c

Please sign in to comment.