Skip to content

Commit

Permalink
Merge remote-tracking branches 'regmap/topic/irq', 'regmap/topic/le',…
Browse files Browse the repository at this point in the history
… 'regmap/topic/mmio' and 'regmap/topic/rbtree' into regmap-next
  • Loading branch information
Mark Brown committed Jun 2, 2014
5 parents e635332 + e128920 + 4aa8c06 + 88cb32c + 70d383b commit 522168d
Show file tree
Hide file tree
Showing 4 changed files with 86 additions and 12 deletions.
8 changes: 4 additions & 4 deletions drivers/base/regmap/regcache-rbtree.c
Original file line number Diff line number Diff line change
Expand Up @@ -23,16 +23,16 @@ static int regcache_rbtree_write(struct regmap *map, unsigned int reg,
static int regcache_rbtree_exit(struct regmap *map);

struct regcache_rbtree_node {
/* the actual rbtree node holding this block */
struct rb_node node;
/* base register handled by this block */
unsigned int base_reg;
/* block of adjacent registers */
void *block;
/* Which registers are present */
long *cache_present;
/* base register handled by this block */
unsigned int base_reg;
/* number of registers available in the block */
unsigned int blklen;
/* the actual rbtree node holding this block */
struct rb_node node;
} __attribute__ ((packed));

struct regcache_rbtree_ctx {
Expand Down
9 changes: 6 additions & 3 deletions drivers/base/regmap/regmap-irq.c
Original file line number Diff line number Diff line change
Expand Up @@ -10,13 +10,13 @@
* published by the Free Software Foundation.
*/

#include <linux/export.h>
#include <linux/device.h>
#include <linux/regmap.h>
#include <linux/irq.h>
#include <linux/export.h>
#include <linux/interrupt.h>
#include <linux/irq.h>
#include <linux/irqdomain.h>
#include <linux/pm_runtime.h>
#include <linux/regmap.h>
#include <linux/slab.h>

#include "internal.h"
Expand Down Expand Up @@ -347,6 +347,9 @@ int regmap_add_irq_chip(struct regmap *map, int irq, int irq_flags,
int ret = -ENOMEM;
u32 reg;

if (chip->num_regs <= 0)
return -EINVAL;

for (i = 0; i < chip->num_irqs; i++) {
if (chip->irqs[i].reg_offset % map->reg_stride)
return -EINVAL;
Expand Down
29 changes: 24 additions & 5 deletions drivers/base/regmap/regmap-mmio.c
Original file line number Diff line number Diff line change
Expand Up @@ -66,12 +66,31 @@ static inline void regmap_mmio_count_check(size_t count, u32 offset)
BUG_ON(count <= offset);
}

static inline unsigned int
regmap_mmio_get_offset(const void *reg, size_t reg_size)
{
switch (reg_size) {
case 1:
return *(u8 *)reg;
case 2:
return *(u16 *)reg;
case 4:
return *(u32 *)reg;
#ifdef CONFIG_64BIT
case 8:
return *(u64 *)reg;
#endif
default:
BUG();
}
}

static int regmap_mmio_gather_write(void *context,
const void *reg, size_t reg_size,
const void *val, size_t val_size)
{
struct regmap_mmio_context *ctx = context;
u32 offset;
unsigned int offset;
int ret;

regmap_mmio_regsize_check(reg_size);
Expand All @@ -82,7 +101,7 @@ static int regmap_mmio_gather_write(void *context,
return ret;
}

offset = *(u32 *)reg;
offset = regmap_mmio_get_offset(reg, reg_size);

while (val_size) {
switch (ctx->val_bytes) {
Expand Down Expand Up @@ -118,7 +137,7 @@ static int regmap_mmio_gather_write(void *context,
static int regmap_mmio_write(void *context, const void *data, size_t count)
{
struct regmap_mmio_context *ctx = context;
u32 offset = ctx->reg_bytes + ctx->pad_bytes;
unsigned int offset = ctx->reg_bytes + ctx->pad_bytes;

regmap_mmio_count_check(count, offset);

Expand All @@ -131,7 +150,7 @@ static int regmap_mmio_read(void *context,
void *val, size_t val_size)
{
struct regmap_mmio_context *ctx = context;
u32 offset;
unsigned int offset;
int ret;

regmap_mmio_regsize_check(reg_size);
Expand All @@ -142,7 +161,7 @@ static int regmap_mmio_read(void *context,
return ret;
}

offset = *(u32 *)reg;
offset = regmap_mmio_get_offset(reg, reg_size);

while (val_size) {
switch (ctx->val_bytes) {
Expand Down
52 changes: 52 additions & 0 deletions drivers/base/regmap/regmap.c
Original file line number Diff line number Diff line change
Expand Up @@ -192,6 +192,13 @@ static void regmap_format_16_be(void *buf, unsigned int val, unsigned int shift)
b[0] = cpu_to_be16(val << shift);
}

static void regmap_format_16_le(void *buf, unsigned int val, unsigned int shift)
{
__le16 *b = buf;

b[0] = cpu_to_le16(val << shift);
}

static void regmap_format_16_native(void *buf, unsigned int val,
unsigned int shift)
{
Expand All @@ -216,6 +223,13 @@ static void regmap_format_32_be(void *buf, unsigned int val, unsigned int shift)
b[0] = cpu_to_be32(val << shift);
}

static void regmap_format_32_le(void *buf, unsigned int val, unsigned int shift)
{
__le32 *b = buf;

b[0] = cpu_to_le32(val << shift);
}

static void regmap_format_32_native(void *buf, unsigned int val,
unsigned int shift)
{
Expand All @@ -240,13 +254,27 @@ static unsigned int regmap_parse_16_be(const void *buf)
return be16_to_cpu(b[0]);
}

static unsigned int regmap_parse_16_le(const void *buf)
{
const __le16 *b = buf;

return le16_to_cpu(b[0]);
}

static void regmap_parse_16_be_inplace(void *buf)
{
__be16 *b = buf;

b[0] = be16_to_cpu(b[0]);
}

static void regmap_parse_16_le_inplace(void *buf)
{
__le16 *b = buf;

b[0] = le16_to_cpu(b[0]);
}

static unsigned int regmap_parse_16_native(const void *buf)
{
return *(u16 *)buf;
Expand All @@ -269,13 +297,27 @@ static unsigned int regmap_parse_32_be(const void *buf)
return be32_to_cpu(b[0]);
}

static unsigned int regmap_parse_32_le(const void *buf)
{
const __le32 *b = buf;

return le32_to_cpu(b[0]);
}

static void regmap_parse_32_be_inplace(void *buf)
{
__be32 *b = buf;

b[0] = be32_to_cpu(b[0]);
}

static void regmap_parse_32_le_inplace(void *buf)
{
__le32 *b = buf;

b[0] = le32_to_cpu(b[0]);
}

static unsigned int regmap_parse_32_native(const void *buf)
{
return *(u32 *)buf;
Expand Down Expand Up @@ -608,6 +650,11 @@ struct regmap *regmap_init(struct device *dev,
map->format.parse_val = regmap_parse_16_be;
map->format.parse_inplace = regmap_parse_16_be_inplace;
break;
case REGMAP_ENDIAN_LITTLE:
map->format.format_val = regmap_format_16_le;
map->format.parse_val = regmap_parse_16_le;
map->format.parse_inplace = regmap_parse_16_le_inplace;
break;
case REGMAP_ENDIAN_NATIVE:
map->format.format_val = regmap_format_16_native;
map->format.parse_val = regmap_parse_16_native;
Expand All @@ -629,6 +676,11 @@ struct regmap *regmap_init(struct device *dev,
map->format.parse_val = regmap_parse_32_be;
map->format.parse_inplace = regmap_parse_32_be_inplace;
break;
case REGMAP_ENDIAN_LITTLE:
map->format.format_val = regmap_format_32_le;
map->format.parse_val = regmap_parse_32_le;
map->format.parse_inplace = regmap_parse_32_le_inplace;
break;
case REGMAP_ENDIAN_NATIVE:
map->format.format_val = regmap_format_32_native;
map->format.parse_val = regmap_parse_32_native;
Expand Down

0 comments on commit 522168d

Please sign in to comment.