Skip to content

Commit

Permalink
mfd/tc3589x: undo gpio module reset during chip init
Browse files Browse the repository at this point in the history
Skip putting the GPIO module into a reset during the chip init.  This makes
sure to preserve any existing GPIO configurations done by pre-kernel boot code.

Acked-by: Samuel Ortiz <sameo@linux.intel.com>
Signed-off-by: Sundar Iyer <sundar.iyer@stericsson.com>
Signed-off-by: Linus Walleij <linus.walleij@stericsson.com>
  • Loading branch information
Sundar Iyer authored and Linus Walleij committed Dec 19, 2010
1 parent bd77efd commit 523bc38
Showing 1 changed file with 6 additions and 3 deletions.
9 changes: 6 additions & 3 deletions drivers/mfd/tc3589x.c
Original file line number Diff line number Diff line change
Expand Up @@ -231,12 +231,15 @@ static int tc3589x_chip_init(struct tc3589x *tc3589x)

dev_info(tc3589x->dev, "manufacturer: %#x, version: %#x\n", manf, ver);

/* Put everything except the IRQ module into reset */
/*
* Put everything except the IRQ module into reset;
* also spare the GPIO module for any pin initialization
* done during pre-kernel boot
*/
ret = tc3589x_reg_write(tc3589x, TC3589x_RSTCTRL,
TC3589x_RSTCTRL_TIMRST
| TC3589x_RSTCTRL_ROTRST
| TC3589x_RSTCTRL_KBDRST
| TC3589x_RSTCTRL_GPIRST);
| TC3589x_RSTCTRL_KBDRST);
if (ret < 0)
return ret;

Expand Down

0 comments on commit 523bc38

Please sign in to comment.