Skip to content

Commit

Permalink
x86/oprofile: Modify initialization of num_virt_counters
Browse files Browse the repository at this point in the history
Models that do not yet support counter multiplexing have to setup
num_virt_counters. This patch implements the setup from num_counters
if num_virt_counters is not set. Thus, num_virt_counters must be setup
only for multiplexing support.

Signed-off-by: Robert Richter <robert.richter@amd.com>
  • Loading branch information
Robert Richter committed Jul 20, 2009
1 parent 2904a52 commit 52471c6
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 3 deletions.
3 changes: 3 additions & 0 deletions arch/x86/oprofile/nmi_int.c
Original file line number Diff line number Diff line change
Expand Up @@ -674,6 +674,9 @@ int __init op_nmi_init(struct oprofile_operations *ops)
if (ret)
return ret;

if (!model->num_virt_counters)
model->num_virt_counters = model->num_counters;

init_sysfs();
using_nmi = 1;
printk(KERN_INFO "oprofile: using NMI interrupt.\n");
Expand Down
2 changes: 0 additions & 2 deletions arch/x86/oprofile/op_model_p4.c
Original file line number Diff line number Diff line change
Expand Up @@ -698,7 +698,6 @@ static void p4_shutdown(struct op_msrs const * const msrs)
struct op_x86_model_spec op_p4_ht2_spec = {
.num_counters = NUM_COUNTERS_HT2,
.num_controls = NUM_CONTROLS_HT2,
.num_virt_counters = NUM_COUNTERS_HT2,
.fill_in_addresses = &p4_fill_in_addresses,
.setup_ctrs = &p4_setup_ctrs,
.check_ctrs = &p4_check_ctrs,
Expand All @@ -711,7 +710,6 @@ struct op_x86_model_spec op_p4_ht2_spec = {
struct op_x86_model_spec op_p4_spec = {
.num_counters = NUM_COUNTERS_NON_HT,
.num_controls = NUM_CONTROLS_NON_HT,
.num_virt_counters = NUM_COUNTERS_NON_HT,
.fill_in_addresses = &p4_fill_in_addresses,
.setup_ctrs = &p4_setup_ctrs,
.check_ctrs = &p4_check_ctrs,
Expand Down
1 change: 0 additions & 1 deletion arch/x86/oprofile/op_model_ppro.c
Original file line number Diff line number Diff line change
Expand Up @@ -206,7 +206,6 @@ static void ppro_shutdown(struct op_msrs const * const msrs)
struct op_x86_model_spec op_ppro_spec = {
.num_counters = 2,
.num_controls = 2,
.num_virt_counters = 2,
.reserved = MSR_PPRO_EVENTSEL_RESERVED,
.fill_in_addresses = &ppro_fill_in_addresses,
.setup_ctrs = &ppro_setup_ctrs,
Expand Down

0 comments on commit 52471c6

Please sign in to comment.