Skip to content

Commit

Permalink
udf: Fix BUG_ON() in destroy_inode()
Browse files Browse the repository at this point in the history
udf_clear_inode() can leave behind buffers on mapping's i_private list (when
we truncated preallocation). Call invalidate_inode_buffers() so that the list
is properly cleaned-up before we return from udf_clear_inode(). This is ugly
and suggest that we should cleanup preallocation earlier than in clear_inode()
but currently there's no such call available since drop_inode() is called under
inode lock and thus is unusable for disk operations.

Signed-off-by: Jan Kara <jack@suse.cz>
  • Loading branch information
Jan Kara committed Nov 27, 2008
1 parent ed31348 commit 52b19ac
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 0 deletions.
1 change: 1 addition & 0 deletions fs/buffer.c
Original file line number Diff line number Diff line change
Expand Up @@ -878,6 +878,7 @@ void invalidate_inode_buffers(struct inode *inode)
spin_unlock(&buffer_mapping->private_lock);
}
}
EXPORT_SYMBOL(invalidate_inode_buffers);

/*
* Remove any clean buffers from the inode's buffer list. This is called
Expand Down
1 change: 1 addition & 0 deletions fs/udf/inode.c
Original file line number Diff line number Diff line change
Expand Up @@ -106,6 +106,7 @@ void udf_clear_inode(struct inode *inode)
udf_truncate_tail_extent(inode);
unlock_kernel();
write_inode_now(inode, 0);
invalidate_inode_buffers(inode);
}
iinfo = UDF_I(inode);
kfree(iinfo->i_ext.i_data);
Expand Down

0 comments on commit 52b19ac

Please sign in to comment.